Bug#891867: diffoscope: improve .changes diffs

Helmut Grohne helmut at subdivi.de
Thu Mar 1 21:20:00 UTC 2018


Control: tags -1 - patch

On Thu, Mar 01, 2018 at 09:00:27PM +0000, Chris Lamb wrote:
> Why not .strip() them all instead, out of interest?

Feel free to do so. I just felt that changing the type from str to
List(str) would be non-trivial and I couldn't immediately figure out
whether that works as intended. It would have the additional benefit of
also removing the indentation. When removing the first line you get the
very same problem with indentation rather than newline. Diff these
against one another:

"line1\n line2\n line3"
"line1\n line2"
"line2\n line3"

So yeah, we need a better solution here.

Helmut



More information about the Reproducible-builds mailing list