Bug#904685: diffoscope: RuntimeError when trying to extract an encrypted file (.bmp)

[Ricardo Gaviria]

Hi Chris,

Based on this bug, please find attached a proposed patch for handling this
error gracefully by catching any exceptions caused by trying to open an
encrypted file in an archive. and forwarding it on as a
*ContainerExtractionError*.

I would gladly appreciate some feedback. I tried to update the changelog as
best as I understood here
<https://reproducible-builds.org/contribute/#Fixing_issues>.

Additionally, I see that I could have also just submitted a merge request
via salsa.debian.org. What is the usual workflow, email patches or merge
requests?

Regards,
Ricardo

On Fri, Jul 27, 2018 at 5:28 PM Ricardo Gaviria <ricardo at unitelabs.ch>
wrote:

> Perfect! thanks for the clarification. Will look into it so ;)
>
> P.S. I love diffoscope!
>
> On Fri, Jul 27, 2018 at 5:26 PM Chris Lamb <lamby at debian.org> wrote:
>
>> Hi Ricardo,
>>
>> > By the way, if this is a lower priority bug than others. I will gladly
>> have
>> > a look into the issue and try and resolve it, provided that we agree on
>> the
>> > expected behaviour of the tool under such a scenario.
>>
>> AIUI the *ideal* behaviour would be that encrypted files would:
>>
>>   a) Not cause a traceback
>>   b) Be marked as such in the diff (see `add_comment` in the code)
>>   c) Be compared in a fallback (ie. binary) fashion
>>
>> Hope that helps. :)
>>
>>
>> Regards,
>>
>> --
>>       ,''`.
>>      : :'  :     Chris Lamb
>>      `. `'`      lamby at debian.org / chris-lamb.co.uk
>>        `-
>>
> --
> Regards,
> Ricardo Gaviria
> Software Engineer, UniteLabs
> *M: *+41 77 956 2376 <+41%2077%20956%2023%2076>
> *W: *http://unitelabs.ch
> *In: *https://www.linkedin.com/in/ricardogaviria/
>
> --
Regards,
Ricardo Gaviria
Software Engineer, UniteLabs
*M: *+41 77 956 2376
*W: *http://unitelabs.ch
*In: *https://www.linkedin.com/in/ricardogaviria/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/reproducible-builds/attachments/20180804/0547cb9d/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Handle-error-when-encrypted-file-is-exctracted-insid.patch
Type: text/x-patch
Size: 2045 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/reproducible-builds/attachments/20180804/0547cb9d/attachment.bin>