[Rsbackup-maint] Bug#773181: rsbackup: unowned files after purge (policy 6.8, 10.8): /etc/rsbackup/local

[Andreas Beckmann]

On 2014-12-16 22:29, Richard Kettlewell wrote:
> (I'm upstream for rsbackup.)
> 
> Andreas Beckmann wrote:
>> during a test with piuparts I noticed your package left unowned files on
>> the system after purge, which is a violation of policy 6.8 (or 10.8):
>>
>> https://www.debian.org/doc/debian-policy/ch-maintainerscripts.html#s-removedetails
>>
> 
> As far as I can see that reference doesn't explain what purge should
> actually do, merely when it is run.  Is there some better documentation
> available?  I'm rather in the dark about how to respond to this.

I'm sure there is. I just can't find it right now :-)

purging deletes configuration files and should clean up everything the
package may have left around ... to leave the system like the package
was never installed.

> My current best guess is:
> 
> https://github.com/ewxrjk/rsbackup/commit/b1283baf

The intention is right, but

  rmdir --ignore-fail-on-non-empty /etc/rsbackup

needs to check for directory existence first. That command will fail if
the directory cannot be removed because it is not there.

And OH MY GOD for

  cp debian/${PACKAGE}.postrm debian/${PACKAGE}/DEBIAN/postrm

Please consider switching to using dh/debhelper for the packaging - do
not do this by hand. I won't mind reviewing it :-) But: do this only
after jessie was released, now in deep freeze is not the right time for
such invasive changes.


Andreas