[sane-devel] teco1 backend ready for inclusion

Henning Meier-Geinitz henning@meier-geinitz.de
Mon, 8 Apr 2002 19:48:26 +0200


Hi,

On Sun, Apr 07, 2002 at 06:23:03PM -0500, Frank Zago wrote:
> Could someone review it before I add add it to the cvs tree:

Ok, let's see what I can find:

* The name is "teco1" but in AUTHORS you name it just "teco" (?)
* backend/Makefile.in contains teco1.desc (try "make dist" to find files
  added erroneously to DISTFILES).
* x_range and y_range must be made static. Compilation fails otherwise
  when compiling static binaries. This is because v4l also defines
  x_range and y_range non-static. I will fix v4l.
  I have just added an extension to "make libcheck" to CVS. It now
  checks also for exported variables. Use static linking for make
  libcheck.
* sane_set_io_mode must return SANE_STATUS_GOOD if non_blocking is
  SANE_FALSE (see standard 4.3.12). Probably wrong in many backends, I
  have found out about this only some days ago :-)
* teco1.desc: remove the parentheses around the version number.

Bye,
  Henning