[sane-devel] Please review

[Henning Meier-Geinitz]

Hi,

On Tue, Nov 19, 2002 at 01:55:31PM +0100, Michael Herder wrote:
> quoting backend-writing.txt:
> "If you don't have access to other platforms, ask sane-devel."
> 
> I'd like to add a new backend "artec_eplus48u" (formerly known as 
> tevion9693usb) to CVS. Since I have no idea, whether this thing compiles on 
> other platforms than Linux, could someone please test it?

Ok. First some general comments:

Your .conf file says:

# tevion9693usb - SANE Backend configuration file
--> artec_eplus48u

# The USB section:
# each device needs at least the following line:
# - [usb] vendor-ID and product-ID
--> but you use "usb ... ... " not "[usb]" ... ... "

option tevionFirmwareFile <path>/Artec48.usb
--> artecFirmwareFile

Manpage:
Add 
@PACKAGEVERSION@ "SANE Scanner Access Now Easy"
to your .TH. See the manpage thread on sane-devel.

Use "\-" instead of "-" in the line after .SH NAME:
sane-artec_eplus48u \- SANE backend for the scanner Artec E+ 48U and re-badged models

artecFirmwareFile instead of tevion

doc/Makefile.in: make dist fails, your addition to DIST needs a .man
extension.

Sourcecode: please run indent -gnu, to make it
GNU-coding-standard-compatible.

Linux x86 2.4, gcc 3.0.4:
Lots of warnings like:
artec_eplus48u.c:1027: warning: void format, Artec48U_Device arg (arg 4)
Not really important, but a (void *) should do the trick.
Otherwise it compiles fine.

Compaq Tru64 Unix 5.1A Alpha, cc
No problems. But I found a bug in gt68xx :-(

OpenBSD 3.1 Alpha, gcc 2.95.3
No problems

HP/UX 11.22 ia64, HP cc A.05.36
No problems

Bye,
  Henning