[sane-devel] "geniusvp2" backend and SANE 1.0.16

Till Kamppeter till.kamppeter at gmx.net
Sat Aug 13 17:28:49 UTC 2005


Oi,

I am packaging SANE 1.0.16 for Mandriva Linux currently. Unfortunately, 
I did not get the patch for the "geniusvp2" backend applied:

-----------------------------------------------------------------------------------
[...]
Patch #19 (sane-backends-1.0.15-geniusvp2-0.2.1.patch.bz2):
+ /usr/bin/bzip2 -d
+ patch -p1 -s
1 out of 3 hunks FAILED -- saving rejects to file backend/Makefile.in.rej
18 out of 130 hunks FAILED -- saving rejects to file configure.rej
^^^^^^^^^^^^^^^^^^^^^^^^^^
The next patch would create the file 
doc/descriptions-external/geniusvp2.desc,
which already exists!  Assume -R? [n] n
Apply anyway? [n] n
1 out of 1 hunk ignored -- saving rejects to file 
doc/descriptions-external/geniusvp2.desc.rej
1 out of 2 hunks FAILED -- saving rejects to file doc/sane.man.rej
error: Bad exit status from /home/tkamppeter/tmp/rpm-tmp.96221 (%prep)
-----------------------------------------------------------------------------------

Can you update your patch? Or better, can you make a distribution 
without patch, having the additional files as usual files and a script 
placing the files in the source tree and adding necessary stuff into the 
configure.in/.ac file and the Makefile.in and then run 
autoconf/automake. In patches you should also never generate patches on 
machine-generated files (like configure) but only on human-entered files 
(like configure.in/.ac), so that the patch gets small and simple. 
Otherwise there is no chance to manually adapt the patch to a new 
version of SANE. The best is to avoid patches as a source tarball. It is 
a maintenance nightmare.

I have temporarily deactivated the "geniusvp2" backend in the Mandriva 
SANE RPM now. I will put it back in as soon as an update is available.

Thanks in advance for your help.

    Till



More information about the sane-devel mailing list