[sane-devel] [PATCH v2 03/14] bldchn, use our new macro SANE_CHECK_NETDB_FUNC

[Chris Bagwell]

On Tue, Jan 24, 2012 at 1:49 PM, Ruediger Meier <sweet_f_a at gmx.de> wrote:
> On Tuesday 24 January 2012, Chris Bagwell wrote:
>> On Mon, Jan 23, 2012 at 5:05 PM, Ruediger Meier <sweet_f_a at gmx.de>
> wrote:
>> > From: Ruediger Meier <ruediger.meier at ga-group.nl>
>> >
>> > Now we will find getaddrinfo and getnameinfo on win32 systems.
>> > Note it should be even safe to use that macro for all systems
>> > instead of trying AC_CHECK_FUNCS first. For now I don't want to do
>> > such risky things things and leave it as is.
>>
>> I would prefer if we went ahead and did your suggestion of doing
>> check with new macro on all systems instead of this.  I will be glad
>> to test on a sampling of Unix systems to make sure there are no
>> issues.
>>
>> So I'm saying I'd prefer this patch to change to delete old check for
>> get* functions and do macro unconditionally.
>
> Ok, then I will polish SANE_CHECK_NETDB_FUNC a little for this:
> 1. maybe allowing multiple args
> 2. respecting cached results
>
>
>> One thing I notice must be a bug.  Right before the old call to
>> AC_CHECK_FUNCS(), there is a check for BeOS and forces the variables
>> to be "no".  Those need to be after the AC_CHECK_FUNCS to be
>> meaningful.
>
> On first view I've also wondered about this but note that all ac_cv_*
> vars are "cached variables" and having them set to "no" before doing
> the check will result it this:
>
> checking for getaddrinfo... (cached) no
> checking for getnameinfo... (cached) no
>
>

Oh yeah.  Thanks for that info.  I not so sure if the logic was
written to work that way but its nice to know we were working.

Chris