[sane-devel] [PATCH v2] backend/plustek-usbdevs.c: Remove trailing whitespace

Paul Menzel paulepanter at users.sourceforge.net
Wed Feb 13 12:25:41 UTC 2013


Date: Wed, 13 Feb 2013 12:17:09 +0100

The following commit introduced two trailing whitespace errors.

    commit 00167c20c53885c062c0e427b4141d1ac6994144
    Author: Gerhard Jaeger <gerhard at gjaeger.de>
    Date:   Wed Feb 13 10:32:28 2013 +0100

        Added support for Q-Scan A6 - see bug report #312073
---
v2: Remove second signature line ---.

1. Please apply this patch again with `git am path/to/mbox/file`.
2. Three remarks, regarding the above commit message.
   a) Normally the imperative should be used instead of past simple. The
Linux kernel is doing that for example. And more logically the automatic
messages by Git command do the same [1].
   b) As Hiroshi seems to have done the major part of the port, it would
have been nice to preserve that metadata.

          git commit --amend --author="Hiroshi Miura <miurahr at linux.com>" --date="Mon Nov 9 06:37:52 2009 +0900"

   c) Alioth URLs are a pain (at least to me). At least I do not know
how easily finding the report. So adding the URL additionally [2] would
save time.

[1] http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html
[2] http://alioth.debian.org/tracker/index.php?func=detail&aid=312073&group_id=30186&atid=410366

 backend/plustek-usbdevs.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/backend/plustek-usbdevs.c b/backend/plustek-usbdevs.c
index 2327b3e..a993e41 100644
--- a/backend/plustek-usbdevs.c
+++ b/backend/plustek-usbdevs.c
@@ -803,11 +803,11 @@ static DCapsDef Cap0x0A53_0x1000 =
  */
 static DCapsDef Cap0x0A53_0x2000 =
 {
-	{{ 0,   0},   0, -1, {1226, 3508}, { 50, 50 }}, 
+	{{ 0,   0},   0, -1, {1226, 3508}, { 50, 50 }},
 	{{ 0,   0},   0,  0, {0, 0}, { 0, 0 }},
 	{{ 0,   0},   0,  0, {0, 0}, { 0, 0 }},
 	{{ 0,   0},   0,  0, {0, 0}, { 0, 0 }},
-	{600, 600},      
+	{600, 600},
 	DEVCAPSFLAG_SheetFed,
 	SENSORORDER_rgb,
 	4,
-- 
1.7.10.4
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.alioth.debian.org/pipermail/sane-devel/attachments/20130213/cd081bb0/attachment.pgp>


More information about the sane-devel mailing list