[sane-devel] [PATCH v2] backend/plustek-usbdevs.c: Remove trailing whitespace
gerhard at gjaeger.de
Wed Feb 13 12:56:39 UTC 2013
On Wednesday 13 February 2013 13:25:41 Paul Menzel wrote:
> Date: Wed, 13 Feb 2013 12:17:09 +0100
> The following commit introduced two trailing whitespace errors.
> 1. Please apply this patch again with `git am path/to/mbox/file`.
> 2. Three remarks, regarding the above commit message.
> a) Normally the imperative should be used instead of past simple. The
> Linux kernel is doing that for example. And more logically the automatic
> messages by Git command do the same .
> b) As Hiroshi seems to have done the major part of the port, it would
> have been nice to preserve that metadata.
to be honest, I struggled with myself before writing this mail and I
do not want to start any kind of flame war. But I'm not sure if
I now should say thank you for the patches or simply reply with
I'm not sure how many hours I've spent on that damned code and the
last thing I would like to see is a sh... comment wrt (2) or some
educational corrections to me or anybody else on this list.
Real help is appreciated, patches are welcome, education in any
direction is counteractive.
More information about the sane-devel