[sane-devel] [PATCH v2] backend/plustek-usbdevs.c: Remove trailing whitespace
paulepanter at users.sourceforge.net
Wed Feb 13 13:35:17 UTC 2013
Am Mittwoch, den 13.02.2013, 13:56 +0100 schrieb Gerhard Jäger:
> On Wednesday 13 February 2013 13:25:41 Paul Menzel wrote:
> > Date: Wed, 13 Feb 2013 12:17:09 +0100
> > The following commit introduced two trailing whitespace errors.
> > 1. Please apply this patch again with `git am path/to/mbox/file`.
> > 2. Three remarks, regarding the above commit message.
> > a) Normally the imperative should be used instead of past simple. The
> > Linux kernel is doing that for example. And more logically the automatic
> > messages by Git command do the same .
> > b) As Hiroshi seems to have done the major part of the port, it would
> > have been nice to preserve that metadata.
> to be honest, I struggled with myself before writing this mail and I
> do not want to start any kind of flame war. But I'm not sure if
> I now should say thank you for the patches or simply reply with
the patches clean the code. So why *PLONK*?
> I'm not sure how many hours I've spent on that damned code and the
> last thing I would like to see is a sh... comment wrt (2) or some
> educational corrections to me or anybody else on this list.
> Real help is appreciated, patches are welcome, education in any
> direction is counteractive.
Come on, you are basically saying that you are not willing to learn and
prefer wasting time by not using the tools correctly (`git show`) and by
even making commits worse and spending time on editing them instead of
doing `git am` three times and `git push`.
I even told you the commands and spend my time fixing errors introduced
with your commits. Believe me that such review and clean up work is not
very entertaining and satisfying either. Taking time to explain stuff to
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 198 bytes
Desc: This is a digitally signed message part
More information about the sane-devel