[sane-devel] Minor message bug in backends/Makefile.am ?

[Olaf Meeuwissen]

Stef writes:

> Hello,
>
>      it seems that the messages in install-becfg from 
> backends/Makefile.am don't use $(DESTDIR). Shouldn't it be like:
>
> diff --git a/backend/Makefile.am b/backend/Makefile.am
> index f84d23e..3f3479c 100644
> --- a/backend/Makefile.am
> +++ b/backend/Makefile.am
> @@ -125,9 +125,9 @@ install-becfg:
>       @list="$(BACKEND_CONFS_ENABLED) saned.conf dll.conf"; for cfg in 
> $$list; do \
>         if test ! -r $${cfg}; then continue; fi; \
>         if test -f $(DESTDIR)$(configdir)/$${cfg}; then \
> -      echo NOT overwriting $${cfg} in $(configdir)...; \
> +      echo NOT overwriting $${cfg} in $(DESTDIR)$(configdir)...; \
>         else \
> -      echo installing $${cfg} in $(configdir)/$${cfg}...; \
> +      echo installing $${cfg} in $(DESTDIR)$(configdir)/$${cfg}...; \
>         $(INSTALL_DATA) $${cfg} $(DESTDIR)$(configdir)/$${cfg} \
>         || exit 1; \
>         fi; \

FWIW, the manual pages and message translations install with the same
message.  That is, these do not insert $(DESTDIR) either.

It looks to me that the `echo` is there to just let the installer see
what is being done (because the recipe start with a `@` and loops).  In
that case, why not just echo the actual command used, as in:

  echo $(INSTALL_DATA) $${cfg} $(DESTDIR)$(configdir)/$${cfg}; \
  $(INSTALL_DATA) $${cfg} $(DESTDIR)$(configdir)/$${cfg}

Not sure what to do with the feedback when "NOT overwriting" but for
debugging purposes I'd prefer a $(DESTDIR) in there.  That way I won't
be sent on a wild goose chase ;-)

Hope this helps,
-- 
Olaf Meeuwissen, LPIC-2           FLOSS Engineer -- AVASYS CORPORATION
FSF Associate Member #1962               Help support software freedom
                 http://www.fsf.org/jf?referrer=1962