[sane-devel] Reflecta ProScan / Crystalscan 7200 PIE film scanner update

Vleeshouwers, J.M. J.M.Vleeshouwers at tue.nl
Mon Mar 11 10:18:04 UTC 2013


Hi Klaus,

Thanks for picking this up again.
You are getting into a process with which I am not familiar at all. But I suppose there will be need for some testing - just let me know whenever that is necessary.
I also remember we still need permission to use a couple of algorithms in the IR-cleanup section.

Yours,

Jan

-----Original Message-----
From: Klaus Kaempf [mailto:kkaempf at suse.de] 
Sent: Friday, March 08, 2013 5:11 PM
To: Paul Menzel
Cc: sane-devel at lists.alioth.debian.org; Michael Rickmann; Vleeshouwers, J.M.
Subject: Re: [sane-devel] Reflecta ProScan / Crystalscan 7200 PIE film scanner update

Hi Paul,

* Paul Menzel <paulepanter at users.sourceforge.net> [Mar 04. 2013 10:34]:
> 
> In my opinion, before committing this upstream you could squash 
> several commits into the original one (as it is not upstream yet). 
> That will keep the commit log cleaner.

sure, no problem. What's the usual process for getting code upstream ?
Are there any coding style guidelines for SANE ?

> 
> If you have even more time and as you found some small errors already 
> and fixed them, you could run Cppcheck and splint on your code (and 
> mention that in the commit message).

My primary goal, besides getting running code, is to make the code clean and maintanable. These tools will certainly help, thanks !

Regards,

Klaus
--
SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg) Maxfeldstraße 5, 90409 Nürnberg, Germany


More information about the sane-devel mailing list