[sane-devel] Reflecta ProScan / Crystalscan 7200 PIE film scanner update

Rolf Bensch rolf at bensch-online.de
Tue Mar 12 13:06:27 UTC 2013


Am 11.03.2013 15:16, schrieb Paul Menzel:
> Dear Klaus,
> Am Freitag, den 08.03.2013, 17:10 +0100 schrieb Klaus Kaempf:
>> * Paul Menzel <paulepanter at users.sourceforge.net> [Mar 04. 2013 10:34]:
>>> In my opinion, before committing this upstream you could squash several
>>> commits into the original one (as it is not upstream yet). That will
>>> keep the commit log cleaner.
>> sure, no problem. What's the usual process for getting code upstream ?
> I am also new to SANE. But sending your patches to the list for review
> and providing a branch to pull from is good way I think.
>> Are there any coding style guidelines for SANE ?
> They are not documented I think. At least I have not found them. You can
> only look at already existing files.

Please have a look here: http://www.sane-project.org/backend-writing.txt.

I found this link here: http://www.sane-project.org/contrib.html.

>>> If you have even more time and as you found some small errors already
>>> and fixed them, you could run Cppcheck and splint on your code (and
>>> mention that in the commit message).
>> My primary goal, besides getting running code, is to make the code
>> clean and maintanable. These tools will certainly help, thanks !
> Awesome!
> Thanks,
> Paul


More information about the sane-devel mailing list