[sane-devel] scanimage / tesseract interoperability
olaf.meeuwissen at avasys.jp
Thu May 29 23:49:29 UTC 2014
Jeff Breidenbach writes:
> Are these two patches on track for inclusion?
> What more can I do to help?
I don't have commit privileges but both look mostly good to me.
Re: names-to-stdout-1.2.diff.gz, you have
@@ -2283,19 +2291,27 @@ List of available devices:", prog_name);
fprintf (stderr, "%s: sane_start: %s\n",
prog_name, sane_strstatus (status));
- fclose (stdout);
+ if (ofp)
+ fclose (ofp);
+ ofp = NULL;
but shouldn't that break statement stay out of the if-branch? Looks to
me like your code has the potential to change program flow.
Re: happy-batch-1.0.diff.gz, why
n >= batch_start_at + batch_increment
and not just
n > batch_start_at
Hope this helps,
Olaf Meeuwissen, LPIC-2 FLOSS Engineer -- AVASYS CORPORATION
FSF Associate Member #1962 Help support software freedom
More information about the sane-devel