[sane-devel] [PATCH 0/3] magicolor 4690MF support

[Olaf Meeuwissen]

Hi,

Eduard - Gabriel Munteanu writes:

> This has been tested on USB only. Please keep me cc-ed for replies,
> as I'm not subscribed to the mailing list.
>
> Eduard - Gabriel Munteanu (3):
>   magicolor: fix USB device detection
>   magicolor: complete support for duplex ADF
>   magicolor: add support for magicolor 4690MF
>
>  backend/magicolor.c             | 27 ++++++++++++++++++++++++---
>  doc/descriptions/magicolor.desc |  6 ++++++
>  2 files changed, 30 insertions(+), 3 deletions(-)

I've done a quick review of the code and made a pu branch so the patches
will not get lost in the mailing list archives.

I only have some concerns about the "FIXME" for the network OID.  Can
the device be used over the network with this value?  If no, then the
network interface should probably be removed from magicolor.desc.

The branch's commits can be found at

  https://gitlab.com/sane-project/backends/commits/pu/magicolor-4690MF-support

@Reinhold, can you take a look and merge this to Alioth's master branch
if it looks okay to you?

Hope this helps,
-- 
Olaf Meeuwissen, LPIC-2            FSF Associate Member since 2004-01-27
Support Free Software               Support the Free Software Foundation
https://my.fsf.org/donate                        https://my.fsf.org/join