[sane-devel] [PATCH 1/2] add PNG format to scanimage
paddy-hack at member.fsf.org
Sat Sep 12 07:13:18 UTC 2015
Thanks for taking the trouble to add optional PNG and JPEG output
I've done a quick review of both patches and there are a few things that
I'd like to point out:
- Why do you let users select PNG/JPEG outputs even when the support is
not available when HAVE_LIBPNG and/or HAVE_LIBJPEG are undefined?
- Aren't you leaking memory? The malloc is inside a do-while but the
free is on the outside.
- It would be nice to update the scanimage manual page to mention the
(potential) support for these image formats.
Hope this helps,
Olaf Meeuwissen, LPIC-2 FSF Associate Member since 2004-01-27
Support Free Software Support the Free Software Foundation
More information about the sane-devel