[sane-devel] [PATCH v3 2/2] add JPEG support to scanimage

[Matteo Croce]

2015-09-17 15:08 GMT+02:00 Olaf Meeuwissen <paddy-hack at member.fsf.org>:
> Hi Matteo,
>
> I also reviewed and tested this in more detail.  The PNG remarks hold
> here as well and the 1-bit output is inverted.
>
> In addition, during testing I used --format=jpg which a bit to my
> surprise led to a PNM image.  I know that was my fault but I thought
> that recognizing this common three letter variant could be supported
> rather easily.
>
> Finally, the documentation for the --batch option uses 'out%d.png'
> twice.  The code uses 'out%d.jpg', without the 'e' ;-)
> Could you fix this too?
>

I tought that "jpeg" was correct as it's the format name, while "jpg"
is just the file extension.
Maybe it's better to have the same string for format and extension,
imagine a script doing:

scanimage --format=$fmt >scan.$fmt

that would be easier to implement of format and extension would match.
I will change it, no problem

-- 
Matteo Croce
OpenWrt Developer
  _______                     ________        __
 |       |.-----.-----.-----.|  |  |  |.----.|  |_
 |   -   ||  _  |  -__|     ||  |  |  ||   _||   _|
 |_______||   __|_____|__|__||________||__|  |____|
          |__| W I R E L E S S   F R E E D O M
 -----------------------------------------------------
 CHAOS CALMER
 -----------------------------------------------------
  * 1 1/2 oz Gin            Shake with a glassful
  * 1/4 oz Triple Sec       of broken ice and pour
  * 3/4 oz Lime Juice       unstrained into a goblet.
  * 1 1/2 oz Orange Juice
  * 1 tsp. Grenadine Syrup
 -----------------------------------------------------