[sane-devel] Submit a pull request for an updated scanner driver (Pixma)?
Earle F. Philhower, III
earlephilhower at yahoo.com
Fri May 11 04:03:03 BST 2018
I didn't realize the move to gitlab was so new, but I definitely appreciate the hiccups involved.
I was able to send in the merge request (MR #1, in fact!) from my branch to the sane-projects/backends repo, but as far as I can see only one of the project members (aka write access) can actually do an assignment or add a label. Makes sense, but I'll have to lean on one of the project members for that.
Thanks again,
-EFP3
On Thursday, May 10, 2018, 4:38:39 AM PDT, Olaf Meeuwissen <paddy-hack at member.fsf.org> wrote:
Hi Earle,
Earle F. Philhower, III writes:
> I posted a week or so back about adding in JPEG support for the Canon
> Pixma Maxify backend. This is needed because the ADF on the Maxify
> MB2120 (and probably other Maxify like the MB5000 where the flatbed
> works but ADF doesn't w/the GIT version) can only return data in JPEG
> format, not raw bytes.
>
> I've got working code and can now scan from my ADF or flatbed without
> any issue, in color, grayscale, or lineart with it transparently going
> back and forth from JPEG to RAW.
>
> How can I go about submitting it for review or a pull request?
>
> I've set up a gitlab account, but I don't seem to be able to submit a
> PRs against the sane-devel/backends repo at all. My branch is at
> https://gitlab.com/earlephilhower/backends/tree/pixma_jpeg
> The README and other document in the backends/ repo didn't give me any
> pointers, either. Any direction appreciated. Thanks,
Sorry about that. I had "temporarily" disabled the Merge Request
functionality while trying to hash out some sort of policy[1]. It
faded to the back of my mind and ... well, you just nudged my mind ;-)
[1]: https://gitlab.com/sane-project/ops/issues/5
The notes on [1] and in particular the quote[2] from the website are
good general advice in the mean-time so I've re-enabled Merge Requests
again. You should be able to submit an MR for your changes. When you
do, add the backend/pixma label (and assign @ro-ben and/or @llagendijk
as they are most familiar with that backend).
[2]: https://gitlab.com/sane-project/ops/issues/5#note_63728170
Hope this helps,
--
Olaf Meeuwissen, LPIC-2 FSF Associate Member since 2004-01-27
GnuPG key: F84A2DD9/B3C0 2F47 EA19 64F4 9F13 F43E B8A4 A88A F84A 2DD9
Support Free Software https://my.fsf.org/donate
Join the Free Software Foundation https://my.fsf.org/join
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/sane-devel/attachments/20180511/507c5991/attachment.html>
More information about the sane-devel
mailing list