[sane-devel] Proposal to remove autoconf-generated files from the source repository

Olaf Meeuwissen paddy-hack at member.fsf.org
Mon Jun 17 12:17:16 BST 2019


Hi Rolf, Povilas, list,

Povilas Kanapickas writes:

> Hi Rolf, Olaf,
>
> On 2019-06-16 14:43, Rolf Bensch wrote:
>> Hi Olaf,
>>
>> Unfortunately `./autogen.sh` isn't working with Ubuntu Xenial:

Why do you want to run it in the first place?  I mean, if I were going
to do development on Ubuntu, I'd use Bionic or later.

I believe Rolf's daily builds use the source tarball.  Those include all
generated files.  No need to run ./autogen.sh.

>> $ ./autogen.sh
>> autoreconf: Entering directory `.'
>> autoreconf: running: autopoint --force
>> autopoint: *** The AM_GNU_GETTEXT_VERSION declaration in your configure.ac
>>  file requires the infrastructure from gettext-0.19.8 but
>> this version
>>  is older. Please upgrade to gettext-0.19.8 or newer.
>> autopoint: *** Stop.
>> autoreconf: autopoint failed with exit status: 1
>> patching file ./ltmain.sh
>> Hunk #1 FAILED at 9615.
>> Hunk #2 FAILED at 10073.
>> 2 out of 2 hunks FAILED -- saving rejects to file ./ltmain.sh.rej
>> patch: **** Can't reopen file ./ltmain.sh : No such file or directory
>>
>> Xenial provides gettext-0.19.7.

The gettext version was bumped on 2018-03-16, a year and three months
ago.  That doesn't seem to have caused any trouble so far ;-)

See https://gitlab.com/sane-project/backends/commit/c8d8f05256523cb0aafe24309ea2b3c93bea20f2

> Can we just require version 0.19.7? 0.19.8 doesn't seem to contain
> anything new that would be related to what we're using.

IIRC, the bump to 0.19.8 fixed the AM_PROG_MKDIR_P deprecation warning.

... me goes to take a peek ...

Yup, the commit after that one syncs the generated stuff and replaces
AM_PROG_MKDIR_P with AC_PROG_MKDIR_P in m4/intl.m4 and m4/po.m4.  But,
yes, the upstream changes for that were made before 0.19.7 and by the
looks of it in 0.18.2.

All that said, I don't understand why we should drop the version to
enable **development** on old versions.
For builds, there's a source tarball that has all you need.

Hope this helps,
--
Olaf Meeuwissen, LPIC-2            FSF Associate Member since 2004-01-27
 GnuPG key: F84A2DD9/B3C0 2F47 EA19 64F4 9F13  F43E B8A4 A88A F84A 2DD9
 Support Free Software                        https://my.fsf.org/donate
 Join the Free Software Foundation              https://my.fsf.org/join



More information about the sane-devel mailing list