[sane-devel] [EXTERNAL] Re: [EXTERNAL] Re: Confrmation about license and distribution
Nakamura.Iwao at exc.epson.co.jp
Wed Apr 28 01:58:43 BST 2021
Thank you for your prompt feedback.
> Do you think it is possible to split it at least into an epson2 and epsonds part?
=> We will split patch into an epson2 and epsonds part on the next release.
> Can you also kindly double check which of the added debug output is still necessary after the development of the patch is complete now?
=> We will double check about the above until the next release.
> Looking forward to work together, enjoy the Golden Week!
=> Thank you. I will be out of office from Apr. 29th. to May 9th. Sorry for your inconvenience.
If anybody is possible to review and feedback for "epsonds" part, we appreciate it.
> We have applied many pieces of changes for one improvement and we have
> much difficulties to separate them to smaller patches which are free from dependencies among each patches.
Yes, it is very difficult afterwards if the patch has already been created. Do you think it is possible to split it at least into an epson2 and epsonds part?
> Then, instead of dividing to smaller patches, we would like to apply the followings for your easy to review.
> - Remove commented-out code
Can you also kindly double check which of the added debug output is still necessary after the development of the patch is complete now?
> - Add more comments for your review one by one for each changes
Yes, this will be helpful, too. Much appreciated!
> If you agree the above our approach, we will apply the above changes
> and release again after waiting for other feedback and fixing the known issue (that is explained in the Release Note) around May 24th.
Thank you. I will have a look again at the patch and see if I have further comments.
Looking forward to work together, enjoy the Golden Week!
More information about the sane-devel