[DSE-Dev] Bug#875558: libsemanage: please support nocheck option and profile

[Helmut Grohne]

Source: libsemanage
Version: 2.7-1
Tags: patch
User: helmutg at debian.org
Usertags: rebootstrap

libsemanage Build-Depends on libcunit1-dev. The dependency is only used
for the test suite and can be skipped otherwise. During cross building,
the testsuite cannot be run, so removing libcunit1-dev from the
bootstrap set would be nice.

The attached patch implements support for DEB_BUILD_OPTIONS=nocheck and
adds the nocheck profile to the libcunit1-dev dependency. Note that
debian/rules should not be checking for the nocheck profile here as
anyone supplying the nocheck profile must also supply the option, but
not the other way round.

Note that combining stage1 and nocheck only works after fixing #875551.

I also wonder why your are making test suite failures non-fatal. I
suggest writing down some reason for that in d/rules or removing the "||
true".

Helmut
-------------- next part --------------
diff --minimal -Nru libsemanage-2.7/debian/changelog libsemanage-2.7/debian/changelog
--- libsemanage-2.7/debian/changelog	2017-09-10 01:07:48.000000000 +0200
+++ libsemanage-2.7/debian/changelog	2017-09-12 09:54:04.000000000 +0200
@@ -1,3 +1,10 @@
+libsemanage (2.7-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Support nocheck build profile. (Closes: #-1)
+
+ -- Helmut Grohne <helmut at subdivi.de>  Tue, 12 Sep 2017 09:54:04 +0200
+
 libsemanage (2.7-1) unstable; urgency=medium
 
   * New upstream release
diff --minimal -Nru libsemanage-2.7/debian/control libsemanage-2.7/debian/control
--- libsemanage-2.7/debian/control	2017-09-10 01:07:48.000000000 +0200
+++ libsemanage-2.7/debian/control	2017-09-12 09:54:04.000000000 +0200
@@ -15,7 +15,7 @@
                gem2deb (>= 0.5.0~) <!stage1>,
                libaudit-dev,
                libbz2-dev,
-               libcunit1-dev,
+               libcunit1-dev <!nocheck>,
                libselinux1-dev (>= 2.7),
                libsepol1-dev (>= 2.7),
                libustr-dev,
diff --minimal -Nru libsemanage-2.7/debian/rules libsemanage-2.7/debian/rules
--- libsemanage-2.7/debian/rules	2017-09-10 01:07:48.000000000 +0200
+++ libsemanage-2.7/debian/rules	2017-09-12 09:54:04.000000000 +0200
@@ -75,5 +75,7 @@
 	-chmod -x ${CURDIR}/debian/python-semanage/usr/lib/python*/*-packages/semanage.py
 	-chmod -x ${CURDIR}/debian/python3-semanage/usr/lib/python*/*-packages/semanage.py
 
+ifeq ($(filter nocheck,$(DEB_BUILD_OPTIONS)),)
 override_dh_auto_test:
 	$(MAKE) test || true
+endif