[DSE-Dev] Bug#875558: libsemanage: please support nocheck option and profile

[Laurent Bigonville]

On Tue, 12 Sep 2017 10:05:33 +0200 Helmut Grohne <helmut at subdivi.de> wrote:
 > Source: libsemanage
 > Version: 2.7-1
 > Tags: patch
 > User: helmutg at debian.org
 > Usertags: rebootstrap
 >
 > libsemanage Build-Depends on libcunit1-dev. The dependency is only used
 > for the test suite and can be skipped otherwise. During cross building,
 > the testsuite cannot be run, so removing libcunit1-dev from the
 > bootstrap set would be nice.
 >
 > The attached patch implements support for DEB_BUILD_OPTIONS=nocheck and
 > adds the nocheck profile to the libcunit1-dev dependency. Note that
 > debian/rules should not be checking for the nocheck profile here as
 > anyone supplying the nocheck profile must also supply the option, but
 > not the other way round.
 >
 > Note that combining stage1 and nocheck only works after fixing #875551.
 >
 > I also wonder why your are making test suite failures non-fatal. I
 > suggest writing down some reason for that in d/rules or removing the "||
 > true".

Is that really needed?

+ifeq ($(filter nocheck,$(DEB_BUILD_OPTIONS)),)

Isn't dh_auto_test only called in the case nocheck is not set?