[Android-tools-devel] Fwd: google-android-sdk-docs-installer

Hans-Christoph Steiner hans at at.or.at
Mon Jul 11 14:37:22 UTC 2016


Default: is using http://dl.google.com, it should use https://dl.google.com

Other than that, it looks good.  Combined with the global conf file in
/etc/default/, I think this approach would be great to have in all the
google-android-* packages.

.hc

Mouaad Aallam:
> (cc)
> 
> *Mouaad Aallam*
> 
> ---------- Forwarded message ----------
> From: Mouaad Aallam <mouaad at aallam.com>
> Date: Mon, Jul 11, 2016 at 2:52 PM
> Subject: Re: [Android-tools-devel] google-android-sdk-docs-installer
> To: Hans-Christoph Steiner <hans at at.or.at>
> 
> 
> Looks great overall, nice work with the debconf stuff!  A couple of
>> comments:
>>
>> * I found another mirror that looks active:
>>   http://android-mirror.bugly.qq.com:8080/android/repository/
> 
> 
>> * I'm pretty sure dl-ssl.google.com is deprecated and dl.google.com only
>> works over HTTPS, we should use https://dl.google.com
>> * when the host is called 'dl-ssl', its misleading to use an HTTP
>> connection, i.e. not HTTPS
>> * the debconf choices should include the URL scheme (https://) so people
>> can see what kind of connection they are getting
>>
>> I think it makes sense to use these as the options:
>>
>> * https://dl.google.com
>> * http://mirrors.neusoft.edu.cn
>> * http://android-mirror.bugly.qq.com:8080
>>
> 
> Hello ! :)
> I've taken all your comments in consideration and I push a commit[1] please
> check it, I can apply same changes to other google-android-*-installer
> packages.
> 
> [1]:
> https://anonscm.debian.org/cgit/android-tools/google-android-sdk-docs-installer.git/commit/
> 
> 
> 
> _______________________________________________
> Android-tools-devel mailing list
> Android-tools-devel at lists.alioth.debian.org
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/android-tools-devel
> 



More information about the Android-tools-devel mailing list