Package syrthes - Request for reviewing

[Sylvestre Ledru]

Le dimanche 13 septembre 2009 à 23:14 +0200, Gilles Filippini a écrit :
> Sylvestre Ledru a écrit :
> > Le vendredi 11 septembre 2009 à 17:23 +0200, Gilles Filippini a écrit :
> >> Hi,
> >>
> >> I've packaged the syrthes[0] thermal computation software and since I'm
> >> not a DD I'd appreciate if someone here could have a look at it.
> > 
> > I have a few comments before upload:
> > * please try to follow the rules of the policy [1] (Maintainer field), etc (I updated the fields)
> 
> Oops... I intended to do so - I read the Debian Science Policy Manual
> months ago - but then missed it. Sorry about that.
No worries

> > * There are static lib into your package. Is it really mandatory ?
> > /usr/lib/syrthes/3.4.2/lib/Linux/libsatsyrthes3.4.2_Linux.a
> > /usr/lib/syrthes/3.4.2/lib/Linux/libsyrthes3.4.2_Linux.a
> > /usr/lib/syrthes/3.4.2/lib/Linux/libmainsyrthes3.4.2_Linux.a
> 
> This is the way syrthes is intended to be used. As for Code_Saturne, a
> specific syrthes exe is build for each case. These static libraries
> constitute the syrthes invariant part which is statically linked against
> the exe.
OK, thanks for the information. 

> > 
> > Not blocking:
> > * the manpages don't explain the arguments syrthes2ensight &
> > syrthes_create_case
> 
> Ack. Will do.
Thanks

> > Don't hesitate if you have some questions.
> 
> I can't see the files you updated on the alioth git repo. Have you
> git-pushed them?
Done, sorry for the delay.

Sylvestre