minicom [non-] bug and linux kernel 2.6.25.4

[Adam Lackorzynski]

Hi,

On Tue Jun 17, 2008 at 23:09:10 -0500, R.L. Horn wrote:
> Well, it looks like the minicom/DTR/RTS problem has been resolved (kernel 
> bug), though with no guarantee that it will be fixed before linux-2.6.26.
>
> In the meantime, anyone struggling with minicom not working with a 2.6.25 
> kernel may apply the enclosed kernel patch.  It will work with versions 
> up to and including 2.6.25.7, after which you're on your own (hopefully,  
> 25.8, if there is one, will work correctly).

> --- linux-2.6.25/drivers/serial/8250.c	2008-04-16 21:49:44.000000000 -0500
> +++ linux-2.6.25-new/drivers/serial/8250.c	2008-06-17 06:20:41.000000000 -0500
> @@ -2174,7 +2174,10 @@
>  	}
>  	serial8250_set_mctrl(&up->port, up->port.mctrl);
>  	spin_unlock_irqrestore(&up->port.lock, flags);
> -	tty_termios_encode_baud_rate(termios, baud, baud);
> +
> +	/* Don't rewrite B0 */
> +	if (tty_termios_baud_rate(termios))
> +		tty_termios_encode_baud_rate(termios, baud, baud);
>  }
>  
>  static void

Ok, thanks for your effort! This should also explain why I did not see
this with an USB dongle.

Now, what to do about minicom itself? Just leave it as is and tell
people to use .25.8 (if it will be in there) or apply a fix? What do you
think?



Adam
-- 
Adam                 adam at os.inf.tu-dresden.de
  Lackorzynski         http://os.inf.tu-dresden.de/~adam/