[Nut-upsdev] bcmxcp: stop whining (and log spamming)

[Peter Selinger]

Dear Henning,

did you know that your system log is configurable? See the man pages
for sysklogd(8) and syslog.conf(5). 

"Info" is the lowest log level besides "debug", and is the appropriate
log level for messages on users logging in and out. If you don't like
to see these messages in your system log, configure your syslog to
log only "notice" and higher. 

Communications failures due to faulty hardware (such as you seem to
have) are appropriate to be logged at the "warning" level. If you
don't like to see these messages in your system log, configure your
syslog to log only "error" and higher.

I find the tone of your message offensive, and I would ask you to keep
your anger to yourself. I know you probably feel that all NUT
developers have been conspiring just to make your day miserable, and
that we all have faulty 6-port serial cards behaving exactly like
yours.  However, this is not the case. In general, you will find that
people are more eager to spend their private time helping you if you
ask politely.

-- Peter

Henning Brauer wrote:
> 
> corrupted checksums happen all the time with the 6-port serial card, 
> even when only using one port (and I don't give a shit about the other 
> ports, if anybody has a one-port laying around...)
> so stop whining already.
> 
> $OpenBSD$
> --- drivers/bcmxcp_ser.c.orig	Wed Aug 23 11:15:54 2006
> +++ drivers/bcmxcp_ser.c	Wed Aug 23 11:26:37 2006
> @@ -168,8 +168,8 @@ int get_answer(unsigned char *data, unsi
>  
>  		/* now we have the whole answer from the ups, we can checksum it */
>  		if (!checksum_test(my_buf)) {
> -			ser_comm_fail("checksum error! ");
> -		return -1;
> +			upsdebugx(2, "checksum error!");
> +			return -1;
>  		}
>  
>  		memcpy(data+end_length, my_buf+4, length);
> 
> 
> 
> 
> -- 
> Henning Brauer, hb at bsws.de, henning at openbsd.org
> BS Web Services, http://bsws.de
> OpenBSD-based Webhosting, Mail Services, Managed Servers, ...
> 
> _______________________________________________
> Nut-upsdev mailing list
> Nut-upsdev at lists.alioth.debian.org
> http://lists.alioth.debian.org/mailman/listinfo/nut-upsdev
>