[Nut-upsdev] patch file

Arjen de Korte nut+devel at de-korte.org
Thu Jul 6 14:56:50 UTC 2006

> I'm sending an attached patch file over nut-2.0.3 including a new driver
> for Microsol ups rhino and an update for Microsol solis driver. It was
> tested on x86 and x86_64 archs.

I looked at the patch and found that it by default uses the Portuguese
language. While I understand (as a non-native english speaker myself) your
reasons to prefer your mothertongue, I don't think it is a good idea here.
The NUT drivers are not meant to be very interactive with the user. If
they have to be, it is usually to aid the user in case of debugging
problems in the configuration. Having to translate the messages from the
driver may put some people off. Likewise, I think you should keep comments
and variable names in the source files english only, since quite a few
people from the NUT development team will not be able to comprehend them

Kind regards,
Eindhoven - The Netherlands
Key fingerprint - 66 4E 03 2C 9D B5 CB 9B  7A FE 7E C1 EE 88 BC 57

More information about the Nut-upsdev mailing list