[Nut-upsdev] apcsmart question

[Michal Soltys]

On 11-03-21 21:50, Michal Soltys wrote:
> Before I start any commits.
>
> In patch 2/18 -
> http://lists.alioth.debian.org/pipermail/nut-upsdev/2011-March/005299.html
>
> Two "custom" commands slipped in: ups.firmware.old and
> shutdown.return.grace. In 18/18 I tried to rename them and add
> remainig commands for "hackish" shutdown methods, to make them easily
> callable through e.g. upscmd (for example for testing).
>
> Is it acceptable to add certain commands specific only to some driver
> and documented in its manual page (but otherwise meaningless for the
> rest of the drivers) ? Say with (in this case) a driver prefix, e.g.:
>
> apcsmart.shutdown.grace (@nnn)
> apcsmart.shutdown.grace.h (@nn)
> apcsmart.shutdown.cs (force OB (U), then shutdown.return (S)  - aka 'CS hack')
> apcsmart.firmware.old (V)
>
> If not - how should I approach this ?
>

So any recommendations ? To keep things consistent - I have to either 
revert part of 2/18 (to not have any additional custom commands), or add 
commands e.g. with driver name prefix (as above), if they have no 
standard command that could match them.