[PATCH] imaplib2: Bump from 2.20 to 2.22

Ethan Glasser-Camp glasse at cs.rpi.edu
Mon Apr 11 17:53:47 BST 2011

On 04/11/2011 11:24 AM, Sebastian Spaeth wrote:
> This contains a fixed Time2InternalDate function and a more robust
> socket connection, trying twice and raising an error only when that
> fails (I believe). The actual code changes are rather minor.

I don't see anything objectionable in this code, certainly don't see 
anything that should break.  But I don't really understand why we need 
to connect() twice; is this to work around strange intermittent network 
failures?  It only goes a second time if it gets interrupted by a 
signal.  This isn't related to the starttls stuff, right?

Otherwise, I'd say

Reviewed-by: Ethan Glasser-Camp <ethan at betacantrips.com>


More information about the OfflineIMAP-project mailing list