[pkg-bacula-devel] Bug#658326: Bug#658326: patch for switch to openssl SHA1 implementation

[Alexander Golovko]

On Mon, 14 May 2012 14:48:25 +0200, Luca Capello wrote:
> forwarded 658326 http://bugs.bacula.org/view.php?id=1869
> tags 658326 + patch
> usertags 658326 + debian-packaging
> thanks
>
> Hi there!
>
> Re-adding Kefu and Karl to the Cc:.
>
> On Thu, 10 May 2012 00:06:25 +0200, Alexander Golovko wrote:
>> Fortunally, there are SHA1 implementation in openssl library.
>> Used functions have the same names and arguments and bacula already
>> linked with libssl
>>
>> We need only change headers, makefile.in and remove bad files.
>
> Thank you, forwarded upstream to:
>
>   <http://bugs.bacula.org/view.php?id=1869>
>

I'm afraid, this patch can't be merged into upstream without changes, 
because bacula can be built without SSL support, but with SHA1.
But it will be greate if we will not need to support it always.

>> With this patch, applied to bacula_5.0.2-2.2
>>  - bacula packages sucessfully builded
>>  - patched bacula-director-mysql can backup patched client (whith
>> signature = SHA1 in fileset)
>>  - patched bacula-director-mysql can backup original client (whith
>> signature = SHA1 in fileset)
>>  - for same files in database written the same SHA1 signature for 
>> both
>> patched and original clients.
>
> This means that we can *safely* apply the patch.  Alexander, can you
> do it in the Git repository, directly in the master branch?  You 
> should
> add your patch in debian/patches, something similar to:
>
>
> 
> <http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=commitdiff;h=a64dee5c2199af135e7f91978c61909829756d0b>
>

Ok, i add it into master branch
<http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=commitdiff;h=6c562cfdaffd730c796518233f0d97da08a3891b>



>> OpenSSL all versions has SHA1 functions, so there is big chance 
>> patch
>> can be applied to oldstable too.
>
> Uploading to oldstable/lenny is no more possible, given that it 
> reached
> EOL on 2012-03-10:
>
>   <http://lists.debian.org/E1S6RgP-0006tF-GE@mikado.tilapin.org>
>
> While we could provide a fixed package in the pkg-bacula HTTP space,
> IMHO it is better to focus on stable, thus "obliging" people to move 
> on
> something which is fully supported.
>
> Thx, bye,
> Gismo / Luca

-- 
with best regards,
Alexander Golovko
email: alexandro at ankalagon.ru
xmpp: alexandro at ankalagon.ru