[pymvpa] request for review OUPS WRONG PATCH

[Michael Hanke]

Hi,

On Fri, Apr 24, 2009 at 11:14:41AM +0200, Valentin Haenel wrote:
> er, i think i attached the wrong patch. fracking git commit --amend :-)
> 
> here, use this one instead.

It looks sane to me. I see the advantages of running multiple datasets
for the same sphere setup at once. On the other hand this adds some
magic that just applies to the searchlight measure -- not sure whether
we want that kind of variability among the different measures. I'm not
necessarily opposed to the change...

Did you do some comparison what you actually gain from moving the
dataset loop inside of searchlight in comparison to a simple outer loop
(in terms of speed)? I guess it could be quite a bit...

Oppinions?


Michael

-- 
GPG key:  1024D/3144BE0F Michael Hanke
http://apsy.gse.uni-magdeburg.de/hanke
ICQ: 48230050