[pymvpa] removing some for loops in _smv.py

Valentin Haenel valentin.haenel at gmx.de
Fri Apr 24 14:58:14 UTC 2009


* Michael Hanke <michael.hanke at gmail.com> [090424]:
> Hi,
> 
> On Fri, Apr 24, 2009 at 01:12:02PM +0200, Valentin Haenel wrote:
> > Hi,
> > 
> > we (Tiziano Zito and I) have recently done a little profiling to improve speed.
> > I have attached the patch for it. (this time the right one i hope)
> 
> Thanks for your patch -- seems to work nicely. I applied it (removed
> tiny whitespace error).

cool, what branch did you apply it too?

> Since I guess you are going to send a lot more patches ;-)

that seems likely. 

> it might be
> useful to have a look at:
> 
>   http://www.kernel.org/pub/software/scm/git/docs/git-am.html
> 
> So we can apply them verbatim from the email body and you have full
> control over the commit message and such ...

You should be able to git-am with the attachment, i think. I did a git
format-patch and then used that as attachment for the email. 

But maybe i should be using git-email?

On the other i would like to accept the previous offer from yaroslav to get my
own branch, for example val/master. I already have corrections to the
searchlight patch from earlier, and some more low level libsvm stuff in the
pipeline. ;-)

V-



More information about the Pkg-ExpPsy-PyMVPA mailing list