Bug#745081: game-data-packager: add support for full versions of wolf3d and spear of destiny

[Simon McVittie]

On 16/01/15 13:02, Alexandre Detiste wrote:
> I was thinking of merging the remaining usefull bits from the control
> files in the yaml.

I've thought about that myself, and not having pointless license
incompatibilities is a reasonable reason to not alter the YAML's license
from GPL-2.

> * Section: , Priority: , Architecture: , Multi-Arch: & Maintainer: are
> all fixed values

q2rogue and q2xatrix are actually Architecture: any (and hence not
Multi-Arch: foreign), but yes the Python code can at least supply a
sensible default for these fields.

> * short description = 'data for ' + longname

Reasonable.

> there only remain to move these data in yaml
> - optional version prefix (like "1.42" +39 for RTCW)

Yes. Where the data can only be one version, like RTCW, it seems
reasonable to put it in the dpkg Version - and that makes it easy for me
to bump the dependency in the Free iortcw engine in contrib, if the
iortcw people do a questionably-Free game-data patch that needs to
accompany a new engine.

It's too late to do the same for existing games without playing with
epochs, since 39 is more than most games' version numbers, but we can do
it for new games.

> - opt. Suggests:   (but a full package would allways automaticaly
> recommends it's expansions)

Good idea. We might have to change from

    type: demo
    type: expansion

to

    demo_for: quake2-full-data
    expansion_for: quake2-full-data

to achieve that, but I've been considering doing that anyway.

> - Long Description; could it be used as (part of the) help text ?

I don't think the long description and the help text are the same thing.
The long description tells you what the game data is (and, tbh, is
relatively close to boilerplate), but the help text has to tell you
where to get it.

I'm somewhat tempted to change the long descriptions to something that
is clearly boilerplate and is designed for variable substitutions, like

    This package was built using game-data-packager. It contains
    proprietary game data and must not be redistributed.
    .
    Game: LONGNAME
    .
    Intended for use with: ENGINE_OR_WRAPPER

(where the variables might for instance be "Doom 2: Hell on Earth" and
"doom-engine", or "Quake III: Team Arena" and "quake3") and just
hard-code that, rather than having it come from a separate file. It's
not as if anyone is going to read these descriptions for any purpose
other than "what's this and why is it on my computer?", so they might
as well be boilerplate that covers the key facts: it's non-distributable
(or at least not unambiguously distributable enough for non-free), and
game-data-packager made it.

In particular, naming the developer/publisher doesn't really seem
important here.

> This needs *relicensing* of those bits too.

Yeah, not worth it. Let's leave the YAML GPL-2 unless previous authors
want to make it more permissive.

    S