[pkg-go] Bug#1007794: sia: FTBFS with Go 1.18

[William 'jawn-smith' Wilson]

Package: sia
Severity: important
Tags: patch
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu jammy ubuntu-patch

Dear Maintainer,

sia currently FTBFS with Go 1.18 due to the increased checks for unused
variables

In Ubuntu, the attached patch was applied to achieve the following:


  * Fix FTBFS with Go 1.18


Thanks for considering the patch.


-- System Information:
Debian Release: bookworm/sid
  APT prefers jammy
  APT policy: (500, 'jammy')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.15.0-22-generic (SMP w/32 CPU threads)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
-------------- next part --------------
diff -Nru sia-1.3.0/debian/control sia-1.3.0/debian/control
--- sia-1.3.0/debian/control	2020-09-09 18:21:01.000000000 -0500
+++ sia-1.3.0/debian/control	2022-03-16 15:30:07.000000000 -0500
@@ -1,8 +1,7 @@
 Source: sia
 Section: net
 Priority: optional
-Maintainer: Ubuntu Developers <ubuntu-devel-discuss at lists.ubuntu.com>
-XSBC-Original-Maintainer: Debian Go Packaging Team <pkg-go-maintainers at lists.alioth.debian.org>
+Maintainer: Debian Go Packaging Team <pkg-go-maintainers at lists.alioth.debian.org>
 Uploaders: Free Ekanayaka <freee at debian.org>, Bjorn Dolk <debian at bjorndolk.com>
 Build-Depends: debhelper (>= 10),
                dh-golang,
diff -Nru sia-1.3.0/debian/patches/0003-fix-ftbfs-with-go1.18.patch sia-1.3.0/debian/patches/0003-fix-ftbfs-with-go1.18.patch
--- sia-1.3.0/debian/patches/0003-fix-ftbfs-with-go1.18.patch	1969-12-31 18:00:00.000000000 -0600
+++ sia-1.3.0/debian/patches/0003-fix-ftbfs-with-go1.18.patch	2022-03-16 15:30:05.000000000 -0500
@@ -0,0 +1,31 @@
+Description: Fix FTBFS with Go 1.18
+ Go 1.18 is more strict about unused variables. This package
+ has an unused variable that is currently causing an FTBFS.
+ The change will not be upstreamed as the repository has
+ been archived by the owner and is therefore read-only.
+Author: William 'jawn-smith' Wilson <jawn-smith at ubuntu.com>
+Origin: Ubuntu
+Forwarded:
+Last-Update: 2022-03-16
+---
+This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
+Index: sia-1.3.0/modules/host/contractmanager/storagefolderempty.go
+===================================================================
+--- sia-1.3.0.orig/modules/host/contractmanager/storagefolderempty.go
++++ sia-1.3.0/modules/host/contractmanager/storagefolderempty.go
+@@ -51,7 +51,6 @@
+ 	wal.mu.Lock()
+ 	storageFolders := wal.cm.availableStorageFolders()
+ 	wal.mu.Unlock()
+-	var syncChan chan struct{}
+ 	for len(storageFolders) >= 1 {
+ 		var storageFolderIndex int
+ 		err := func() error {
+@@ -134,7 +133,6 @@
+ 			delete(wal.cm.sectorLocations, oldSU.ID)
+ 			delete(sf.availableSectors, id)
+ 			wal.cm.sectorLocations[id] = sl
+-			syncChan = wal.syncChan
+ 			wal.mu.Unlock()
+ 			return nil
+ 		}()
diff -Nru sia-1.3.0/debian/patches/series sia-1.3.0/debian/patches/series
--- sia-1.3.0/debian/patches/series	2017-10-31 18:54:54.000000000 -0500
+++ sia-1.3.0/debian/patches/series	2022-03-16 15:28:11.000000000 -0500
@@ -1,2 +1,3 @@
 0001-fix-log-dir.patch
 0002-inconshreveable-muxado.patch
+0003-fix-ftbfs-with-go1.18.patch