[pkg-go] Bug#1044269: gitaly: Fails to build source after successful build

[Lucas Nussbaum]

Source: gitaly
Version: 16.0.7+ds1-3
Severity: minor
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
User: debian-qa at lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
> cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S
> ------------------------------------------------------------------------------------------------------------------------
> 
> dpkg-buildpackage: info: source package gitaly
> dpkg-buildpackage: info: source version 16.0.7+ds1-3
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by Pirate Praveen <praveen at debian.org>
>  dpkg-source --before-build .
>  fakeroot debian/rules clean
> dh clean  --buildsystem=golang --with=golang --package=golang-gitlab-gitlab-org-gitaly-dev \
> --builddirectory=_build
>    debian/rules override_dh_auto_clean
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> rm -rf ruby/proto/gitaly/*_pb.rb
> dh_auto_clean -O--buildsystem=golang -O--package=golang-gitlab-gitlab-org-gitaly-dev \
> -O--builddirectory=_build
> dh_auto_clean -O--buildsystem=ruby -O--package=ruby-gitaly
> dh_auto_clean: warning: No packages to build. Possible architecture mismatch: amd64, want: all any
> make[1]: Leaving directory '/<<PKGBUILDDIR>>'
>    dh_autoreconf_clean -O--buildsystem=golang -O--package=golang-gitlab-gitlab-org-gitaly-dev -O--builddirectory=_build
>    dh_clean -O--buildsystem=golang -O--package=golang-gitlab-gitlab-org-gitaly-dev -O--builddirectory=_build
> dh clean  --buildsystem=ruby --with=ruby --package=ruby-gitaly
>    debian/rules override_dh_auto_clean
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> rm -rf ruby/proto/gitaly/*_pb.rb
> dh_auto_clean -O--buildsystem=golang -O--package=golang-gitlab-gitlab-org-gitaly-dev \
> -O--builddirectory=_build
> dh_auto_clean: warning: No packages to build. Possible architecture mismatch: amd64, want: all any
> dh_auto_clean -O--buildsystem=ruby -O--package=ruby-gitaly
> 	dh_ruby --clean
> W: XS-Ruby-Versions is deprecated, and will be ignored
> make[1]: Leaving directory '/<<PKGBUILDDIR>>'
>    dh_autoreconf_clean -O--buildsystem=ruby -O--package=ruby-gitaly
>    dh_clean -O--buildsystem=ruby -O--package=ruby-gitaly
> dh clean  --package=gitlab-common
>    debian/rules override_dh_auto_clean
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> rm -rf ruby/proto/gitaly/*_pb.rb
> dh_auto_clean -O--buildsystem=golang -O--package=golang-gitlab-gitlab-org-gitaly-dev \
> -O--builddirectory=_build
> dh_auto_clean: warning: No packages to build. Possible architecture mismatch: amd64, want: all any
> dh_auto_clean -O--buildsystem=ruby -O--package=ruby-gitaly
> dh_auto_clean: warning: No packages to build. Possible architecture mismatch: amd64, want: all any
> make[1]: Leaving directory '/<<PKGBUILDDIR>>'
>    dh_autoreconf_clean -O--package=gitlab-common
>    dh_clean -O--package=gitlab-common
> dh clean  --package=gitaly
>    debian/rules override_dh_auto_clean
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> rm -rf ruby/proto/gitaly/*_pb.rb
> dh_auto_clean -O--buildsystem=golang -O--package=golang-gitlab-gitlab-org-gitaly-dev \
> -O--builddirectory=_build
> dh_auto_clean: warning: No packages to build. Possible architecture mismatch: amd64, want: all any
> dh_auto_clean -O--buildsystem=ruby -O--package=ruby-gitaly
> dh_auto_clean: warning: No packages to build. Possible architecture mismatch: amd64, want: all any
> make[1]: Leaving directory '/<<PKGBUILDDIR>>'
>    dh_autoreconf_clean -O--package=gitaly
>    dh_clean -O--package=gitaly
>  dpkg-source -b .
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: building gitaly using existing ./gitaly_16.0.7+ds1.orig-vendor.tar.xz
> dpkg-source: info: building gitaly using existing ./gitaly_16.0.7+ds1.orig.tar.xz
> dpkg-source: info: using patch list from debian/patches/series
> dpkg-source: warning: ignoring deletion of directory tools/protoc-gen-doc
> dpkg-source: warning: ignoring deletion of file tools/protoc-gen-doc/tool.go, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file tools/protoc-gen-doc/go.sum, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file tools/protoc-gen-doc/go.mod, use --include-removal to override
> dpkg-source: warning: ignoring deletion of directory tools/golangci-lint
> dpkg-source: warning: ignoring deletion of file tools/golangci-lint/tool.go, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file tools/golangci-lint/go.sum, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file tools/golangci-lint/go.mod, use --include-removal to override
> dpkg-source: warning: ignoring deletion of directory tools/golangci-lint/gitaly
> dpkg-source: warning: ignoring deletion of file tools/golangci-lint/gitaly/quote_test.go, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file tools/golangci-lint/gitaly/errorwrap_test.go, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file tools/golangci-lint/gitaly/quote.go, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file tools/golangci-lint/gitaly/lint.go, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file tools/golangci-lint/gitaly/matcher.go, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file tools/golangci-lint/gitaly/errorwrap.go, use --include-removal to override
> dpkg-source: warning: ignoring deletion of directory tools/golangci-lint/gitaly/testdata
> dpkg-source: warning: ignoring deletion of directory tools/golangci-lint/gitaly/testdata/src
> dpkg-source: warning: ignoring deletion of directory tools/golangci-lint/gitaly/testdata/src/quote
> dpkg-source: warning: ignoring deletion of file tools/golangci-lint/gitaly/testdata/src/quote/quote_test.go, use --include-removal to override
> dpkg-source: warning: ignoring deletion of directory tools/golangci-lint/gitaly/testdata/src/errorwrap
> dpkg-source: warning: ignoring deletion of file tools/golangci-lint/gitaly/testdata/src/errorwrap/errorwrap_test.go, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file tools/golangci-lint/gitaly/testdata/src/errorwrap/errorwrap_alias_test.go, use --include-removal to override
> dpkg-source: info: local changes detected, the modified files are:
>  gitaly-16.0.7+ds1/tools/protogem/Gemfile.lock
> dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/gitaly_16.0.7+ds1-3.diff.b961fE
> dpkg-source: info: Hint: make sure the version in debian/changelog matches the unpacked source tree
> dpkg-source: info: you can integrate the local changes with dpkg-source --commit
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
> 
> E: Command 'cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/13/gitaly_16.0.7+ds1-3_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.