[pkg-go] Bug#1045188: libpod: Fails to build source after successful build

[Lucas Nussbaum]

Source: libpod
Version: 4.3.1+ds1-8
Severity: minor
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
User: debian-qa at lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
> cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S
> -----------------------------------------------------------------------------------------------------------------------
> 
> dpkg-buildpackage: info: source package libpod
> dpkg-buildpackage: info: source version 4.3.1+ds1-8
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by Reinhard Tartler <siretart at tauware.de>
>  dpkg-source --before-build .
>  fakeroot debian/rules clean
> dh clean --buildsystem=golang --with=golang,bash-completion --builddirectory=_output
>    dh_auto_clean -O--buildsystem=golang -O--builddirectory=_output
>    dh_autoreconf_clean -O--buildsystem=golang -O--builddirectory=_output
>    dh_clean -O--buildsystem=golang -O--builddirectory=_output
>  dpkg-source -b .
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: building libpod using existing ./libpod_4.3.1+ds1.orig.tar.xz
> dpkg-source: info: using patch list from debian/patches/series
> dpkg-source: info: local changes detected, the modified files are:
>  libpod-4.3.1+ds1/docs/build/man/.dockerignore.5
>  libpod-4.3.1+ds1/docs/build/man/dockerfile.5
>  libpod-4.3.1+ds1/docs/build/man/dockerignore.5
>  libpod-4.3.1+ds1/docs/source/markdown/podman-attach.1.md
>  libpod-4.3.1+ds1/docs/source/markdown/podman-auto-update.1.md
>  libpod-4.3.1+ds1/docs/source/markdown/podman-build.1.md
>  libpod-4.3.1+ds1/docs/source/markdown/podman-container-clone.1.md
>  libpod-4.3.1+ds1/docs/source/markdown/podman-container-runlabel.1.md
>  libpod-4.3.1+ds1/docs/source/markdown/podman-create.1.md
>  libpod-4.3.1+ds1/docs/source/markdown/podman-exec.1.md
>  libpod-4.3.1+ds1/docs/source/markdown/podman-image-sign.1.md
>  libpod-4.3.1+ds1/docs/source/markdown/podman-kill.1.md
>  libpod-4.3.1+ds1/docs/source/markdown/podman-kube-play.1.md
>  libpod-4.3.1+ds1/docs/source/markdown/podman-login.1.md
>  libpod-4.3.1+ds1/docs/source/markdown/podman-logout.1.md
>  libpod-4.3.1+ds1/docs/source/markdown/podman-logs.1.md
>  libpod-4.3.1+ds1/docs/source/markdown/podman-manifest-add.1.md
>  libpod-4.3.1+ds1/docs/source/markdown/podman-manifest-annotate.1.md
>  libpod-4.3.1+ds1/docs/source/markdown/podman-manifest-create.1.md
>  libpod-4.3.1+ds1/docs/source/markdown/podman-manifest-push.1.md
>  libpod-4.3.1+ds1/docs/source/markdown/podman-pause.1.md
>  libpod-4.3.1+ds1/docs/source/markdown/podman-pod-clone.1.md
>  libpod-4.3.1+ds1/docs/source/markdown/podman-pod-create.1.md
>  libpod-4.3.1+ds1/docs/source/markdown/podman-pod-kill.1.md
>  libpod-4.3.1+ds1/docs/source/markdown/podman-pod-logs.1.md
>  libpod-4.3.1+ds1/docs/source/markdown/podman-pod-rm.1.md
>  libpod-4.3.1+ds1/docs/source/markdown/podman-pod-start.1.md
>  libpod-4.3.1+ds1/docs/source/markdown/podman-pod-stats.1.md
>  libpod-4.3.1+ds1/docs/source/markdown/podman-pod-stop.1.md
>  libpod-4.3.1+ds1/docs/source/markdown/podman-pull.1.md
>  libpod-4.3.1+ds1/docs/source/markdown/podman-push.1.md
>  libpod-4.3.1+ds1/docs/source/markdown/podman-restart.1.md
>  libpod-4.3.1+ds1/docs/source/markdown/podman-rm.1.md
>  libpod-4.3.1+ds1/docs/source/markdown/podman-run.1.md
>  libpod-4.3.1+ds1/docs/source/markdown/podman-search.1.md
>  libpod-4.3.1+ds1/docs/source/markdown/podman-start.1.md
>  libpod-4.3.1+ds1/docs/source/markdown/podman-stats.1.md
>  libpod-4.3.1+ds1/docs/source/markdown/podman-stop.1.md
>  libpod-4.3.1+ds1/docs/source/markdown/podman-unpause.1.md
>  libpod-4.3.1+ds1/docs/source/markdown/podman-update.1.md
> dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/libpod_4.3.1+ds1-8.diff.gCvhns
> dpkg-source: info: Hint: make sure the version in debian/changelog matches the unpacked source tree
> dpkg-source: info: you can integrate the local changes with dpkg-source --commit
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
> 
> E: Command 'cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/13/libpod_4.3.1+ds1-8_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.