[pkg-go] Bug#1136557: podman uses pidof but does not depend on procps

[Gioele Barabucci]

Source: podman
Version: 5.8.2+ds1-1
Usertags: pidof-without-procps

Dear maintainer(s) of podman,

it appears that podman uses `pidof` in its testsuite, or that
at least one of its binary packages uses `pidof` at runtime.
Historically, `pidof` was provided by the Essential package
`sysvinit-tools`, making an explicit dependency unnecessary. However
`pidof` will soon be moved to `procps` and will no longer be part of
the Essential set.

Please add an explicit dependency on `procps`:

* via the `Depends:` field of all binary packages of podman
  that use `pidof` at runtime;
* via the `Build-Depends:` field of podman, if `pidof` is
  used in tests run at build-time;
* via the `Depends:` field of `debian/control/tests`, if `pidof` is
  used in autopkgtests.

To prevent any disruption for users of podman, please add
this dependency now, before `pidof` is moved from `sysvinit-utils` to
`procps`. Alternatively, you could remove all uses of `pidof`.

It is believed that podman uses `pidof` due to the following
code snippets:

```
path: podman_5.7.0+ds2-3/test/apiv2/python/rest_api/test_v2_0_0_container.py
        out = r.json()
        self.assertIsNotNone(out["State"].get("Health"))
        self.assertListEqual(["CMD", "pidof", "top"], out["Config"]["Healthcheck"]["Test"])
        self.assertEqual(5000000000, out["Config"]["Healthcheck"]["Interval"])
        self.assertEqual(2000000000, out["Config"]["Healthcheck"]["Timeout"])


path: podman_5.7.0+ds2-3/test/apiv2/python/rest_api/test_v2_0_0_container.py
        out = r.json()
        hc = out["Config"]["Healthcheck"]["Test"]
        self.assertListEqual(["CMD", "pidof", "top"], hc)
        r = requests.post(self.podman_url + f"/v1.40/containers/{container_id}/start")


path: podman_5.7.0+ds2-3/test/apiv2/python/rest_api/test_v2_0_0_container.py
                "Image": "alpine:latest",
                "Healthcheck": {
                    "Test": ["CMD", "pidof", "top"],
                    "Interval": 5000000000,
                    "Timeout": 2000000000,
```

Feel free to close this issue if this is a false positive (for example
if this code is in an unreachable code path).

Regards,

-- 
Gioele Barabucci