[Pkg-javascript-devel] nodejs-12 transition

[Nilesh Patra]

On Sat, 18 Jan 2020 at 01:06, Xavier <yadd at debian.org> wrote:

> Le 17/01/2020 à 18:55, Nilesh Patra a écrit :
> >
> > On Fri, 17 Jan 2020 at 05:02, Pirate Praveen <praveen at onenetbeyond.org
> > <mailto:praveen at onenetbeyond.org>> wrote:
> >
> >     On വെ, Jan 17, 2020 at 07:33, Paolo Greppi <paolo.greppi at libpf.com
> >     <mailto:paolo.greppi at libpf.com>>
> >     wrote:
> >     > Il 16/01/20 20:35, Pirate Praveen ha scritto:
> >     >>
> >     >>
> >     >>  On വ്യാ, Jan 16, 2020 at 13:27, Nilesh Patra
> >     >> <npatra974 at gmail.com <mailto:npatra974 at gmail.com>> wrote:
> >     >>>  Hi,
> >     >>>  I had been lately seeing discussions in the list regarding
> >     >>> requiring transition for nodejs-12 to unstable. I tested all the
> >     >>> reverse depends and this is the list of all failing
> >     >>> reverse-depends[1] and the repository[2] contains all the
> >     >>> individual logs(for all reverse-depends) for convenience.
> >     >>>  Also rebuilt the reverse-build-depends and this[3] is the list
> of
> >     >>> depends that fail and the individual logs are in the same
> >     >>> repository[4]
> >     >>>
> >     >>>  [1];
> >     >>>
> >
> https://git.fosscommunity.in/gi-boi/nodejs_autopkgtest_results/blob/master/rdeps
> >     >>>  [2]:
> >     >>> https://git.fosscommunity.in/gi-boi/nodejs_autopkgtest_results/
> >     >>>  [3]:
> >     >>>
> >
> https://git.fosscommunity.in/gi-boi/nodejs_rebuild_results/blob/master/rebuild_deps
> >     >>>  [4]:
> https://git.fosscommunity.in/gi-boi/nodejs_rebuild_results/
> >     >>>
> >
> > [..]
> >
> >     >>  Thanks a lot Nilesh for doing it. This is really helpful.
> >     >>  Some the failures may be unrelated to nodejs 12 change, for
> example
> >     >>  https://tracker.debian.org/pkg/node-dagre-layout this is already
> >     >> failing (I think thanks to /usr/lib to /usr/share migration).
> >     >> Similarly for autopkgtest. So among the packages that failed, we
> >     >> need to find out which of them are already failing (we can get
> this
> >     >> information from tracker.debian.org <http://tracker.debian.org>).
> >     >>
> >     >>>  Thanks and Regards
> >     >>>  Nilesh
> >     >
> >     > Hi Nilesh and thanks for the good work.
> >     >
> >     > For nodejs_autopkgtest_results, of the 1288 logs only 74 contain
> the
> >     > string 'FAIL non-zero exit status' (see attached
> >     > nodejs_autopkgtest_results-failed).
> >     > I propose to mass-file bugs against each of them for easier
> tracking.
> >
> >     I think a wiki page might be simpler at least for first pass.
> >     See transition of rails 5 for example
> >
> https://salsa.debian.org/ruby-team/rails/-/wikis/Transition-to-Rails-5.2-for-Debian-Buster
> >
> >     For packaes that can't be fixed easily we can file bugs.
> >
> >     > For nodejs_rebuild_results, of the 1168 logs only the 62 in the
> >     > rebdeps file actually failed.
> >     > Some may be false positives as suggested by Praveen; had you used
> >     > ratt [1] you could have told it to retry the failing builds without
> >     > the new package (in this case nodejs 12), this would exclude most
> of
> >     > those that are already failing.
> >     > Who feels like doing it manually now for the 62 failing builds ?
> >
> >     >
> >     Once we have wiki, people can take ownership of a subset and look at
> >     specific packages (dividing the whole work).
> >
> >
> > I have created the wiki page here[1] with relevant reverse and reverse
> > build depends. Updated the autopkgtest failures as per Paolo's list(74
> > in number). The logs are available for individual logs for convenience
> > as well.(marked the mail containing links above)
> >
> > [1]:
> >
> https://salsa.debian.org/js-team/nodejs/-/wikis/Transition-to-Nodejs-12-for-Debian-Unstable
> >
> > Thanks and Regards
> > Nilesh
>
> Hi,
>
> node-tap is ready, was just an output problem. (I forgot to bring my
> Yubikey, then I'm unable to push it for now. NB: can be pushed directly
> to unstable: just 3 tests disabled)
>
> Cheers,
> Xavier
>

Hi,

I was trying to fix node-node-sass to build with nodejs-12. In order to do
that, I first needed to build node-gyp and node-nan, (both native package
and node-node-sass's build-deps) with nodejs-12. While building node-nan
with nodejs-12 (and with node-gyp as --extra-package since it is node-nan's
build-dep), I encounter several of these:

  42) test/js/typedarrays-test.js
Error: The module '/<<PKGBUILDDIR>>/test/build/Release/weak2.node'
was compiled against a different Node.js version using
NODE_MODULE_VERSION 64. This version of Node.js requires
NODE_MODULE_VERSION 72. Please try re-compiling or re-installing
the module (for instance, using `npm rebuild` or `npm install`).
    at Object.Module._extensions..node (internal/modules/cjs/loader.js:1025:18)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Function.Module._load (internal/modules/cjs/loader.js:727:14)
    at Module.require (internal/modules/cjs/loader.js:852:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at bindings (/usr/lib/nodejs/bindings/bindings.js:76:44)
    at Object.<anonymous> (/<<PKGBUILDDIR>>/test/js/weak2-test.js:11:37)
    at Module._compile (internal/modules/cjs/loader.js:959:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:995:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
free(): invalid pointer
test/js/weak-test.js


I'm not sure why that is the case(expecting old nodejs version), since
node-gyp is its only native build-depend. Could someone help understand the
problem, and workaround for it?
Also, node-node-sass builds fine with the current nodejs, (fixed the
reproducible-builds error) I have pushed the changes here[1]

[1]: https://salsa.debian.org/gi-boi-guest/node-node-sass
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/pkg-javascript-devel/attachments/20200118/1c3dcbde/attachment.html>