specific cdbs makefile for kde 4

[Sune Vuorela]

On Saturday 04 August 2007, Fathi Boudra wrote:
> hi,
>
> i'm not convinced by current specific cdbs files (cmake.mk,  kde.mk  and
> utils.mk) used for kde4.

Hi!

I don't know if you have forgotten past discussions or just chosen to ignore 
them.

cmake.mk:
Based on the one submitted by Fathi.  The kde-specific -DFOO needs as 
mentioned several times earlier to be moved to the debian/kde.mk file.
The only difference is IIRC that I have removed this nice piece of nothing:
ifeq (,$(findstring noopt,$(DEB_BUILD_OPTIONS)))
# well, -O0
endif

ifneq (,$(findstring nostrip,$(DEB_BUILD_OPTIONS)))
# semi-debug
else
# final
endif

ifneq (,$(findstring debug,$(DEB_BUILD_OPTIONS)))
# debug
endif

and added the kde specific as mentioned.

The todolist for this is to move the kde4 specific -DFOO to kde.mk.

kde.mk:
kde.mk is the successor of the debian/debian-qt-kde.mk file we currently have. 
It is used for stuff that should be in common for packages. The cmake -DFOO 
we have in cmake.mk should be moved to here where they belong.
kde.mk also contains snippets to decide where to use enable-final, snippets to 
build man pages and to install docs.


utils.mk:
it is utils.mk from cdbs with the patch from 423394 added. The plan is to go 
back to the cdbs utils.mk when this bug is resolved.  We need a way to add 
files that shouldn't show up in the output from utils.mk


The move of the -DFOO from cmake.mk to kde.mk is something that we need to do, 
but I don't see it that important to do yet. I want them to be in a common 
file so that we have the possibilities to change and add stuff in _one_ place 
instead of all the many rules files in all packages


> Using single cmake.mk submitted on #377524 (used by every kde-extras
> packages) and a rules file (around 10 lines and attached), i have builded
> kdelibs/kdepimlibs/kdebase without problems.

As written, the plan is to move to a cdbs provided cmake.mk file. Currently it 
doesn't differ much and the plan is to make it differ even less with moving 
the kde4 specific -DFOO elsewhere.


> i found a "10 lines" rules more readable and easy to fix versus a bunch of
> files touching every KDE4 packages.

It depends on the kind of changes you need to make. When needing to change or 
add a -DFOO to all packages, having it in all rules files is a great pain in 
the arse. This is why we in kde3 packages also have a shared file for such 
stuff.


> so i would like to have some feedbacks on this point, pros/cons, point of
> view, whatever...

Full NACK from here.

/Sune
-- 
How can I cancel the periferic?

You need to explore the SIMM.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
Url : http://lists.alioth.debian.org/pipermail/pkg-kde-talk/attachments/20070805/af345e7a/attachment.pgp