[Pkg-mozext-maintainers] Bug#919557: Bug#919557: Bug#919557: webext-umatrix: garbled display of toolbar menu in Firefox 64.0-1

[Ximin Luo]

Antoine Beaupré:
> On 2019-10-25 11:58:37, Antoine Beaupré wrote:
>> On 2019-09-04 23:05:19, Paul Wise wrote:
>>> On Fri, 22 Feb 2019 07:47:00 +0000 Ximin Luo wrote:
>>>
>>>> For the time being you can work around the issue either by using
>>>> firefox-esr instead of firefox (65) which is why I myself had not yet
>>>> noticed this issue, it was working perfectly fine for me.
>>>
>>> Unfortunately Firefox ESR 68 has now reached Debian unstable.
>>>
>>>> If you cannot run firefox-esr and must run firefox 65, you can also
>>>> work around the issue by running:
>>>>
>>>> $ sudo rm /usr/share/webext/umatrix/lib/punycode.js
>>>> $ sudo cp /usr/share/javascript/punycode/punycode.js /usr/share/webext/umatrix/lib/punycode.js
>>>
>>> This workaround is no longer sufficient to fix the issue. I also tried
>>> removing other symlinks and replacing them with the equivalent files
>>> but this didn't help either.
>>
>> I also see this problem, on Debian 10 buster, after upgrading to FF 68.
>>
>> But what I found strange is that I did the upgrade on two different
>> machines, and one survived: my laptop doesn't have problems with
>> uMatrix, as far as I can tell.
>>
>> Note that this bug also triggers #916594 which means it's impossible to
>> restore from backups.
>>
>> That said, the above "rm + cp" workaround *did* work here,
>> strangely. Not sure what I have different from pabs...
> 
> ... ah. but the bug described in #916594 *does* still happen now: the
> display is correct, but the "My rules" dialog is blank:
> 
> https://paste.anarc.at/publish/2019-10-25-otplYB53oFI/screenshot.png
> 
> The nice thing is that while the "My rules" dialog looks blank, the
> rules *are* actually still there, [..]

This is because codemirror is also symlinked, and that dialog uses codemirror. To work-around locally, do the same thing as for punycode:

$ sudo rm /usr/share/webext/umatrix/lib/codemirror
$ sudo cp -a /usr/share/javascript/codemirror /usr/share/webext/umatrix/lib/codemirror

(Note that due to limitations in dpkg, this workaround persists even if you reinstall webext-umatrix. To undo the workaround, rm -rf the directory *then* reinstall webext-umatrix.)

I've just uploaded a new version of umatrix 1.4.0, and confirmed these workarounds still work with firefox 74. If it doesn't work for you, please try it on a fresh profile.

I've also enabled chromium support and the workaround isn't needed there, chromium traverses these symlinks fine. It really is a firefox bug and the firefox devs refusing to allow this behaviour for "security" reasons don't know what they are talking about.

I would imagine one simply has to find the relevant "if" condition in firefox source code and patch it out of Debian's packaged firefox.

X

-- 
GPG: ed25519/56034877E1F87C35
GPG: rsa4096/1318EFAC5FBBDBCE
https://github.com/infinity0/pubkeys.git