[Pkg-mozext-maintainers] Bug#919557: Bug#919557: webext-umatrix: garbled display of toolbar menu in Firefox 64.0-1

[Paul Wise]

On Sat, 2020-03-21 at 16:44 +0000, Ximin Luo wrote:

> This is because codemirror is also symlinked, and that dialog uses
> codemirror. To work-around locally, do the same thing as for
> punycode:
> 
> $ sudo rm /usr/share/webext/umatrix/lib/codemirror
> $ sudo cp -a /usr/share/javascript/codemirror
> /usr/share/webext/umatrix/lib/codemirror

I've purged webext-umatrix and removed all of the workarounds I had
before. Then I installed webext-umatrix 1.4.0+dfsg-1.

These symlinks were present after that:

   $ find /usr/share/webext/umatrix/ -type l -ls
    27034549      0 lrwxrwxrwx   1 root     root           30 Mar 22 00:34 /usr/share/webext/umatrix/lib/codemirror -> ../../../javascript/codemirror
    27034550      0 lrwxrwxrwx   1 root     root           40 Mar 22 00:34 /usr/share/webext/umatrix/lib/punycode.js -> ../../../javascript/punycode/punycode.js
    27034547      0 lrwxrwxrwx   1 root     root           42 Mar 22 00:34 /usr/share/webext/umatrix/css/fonts/Roboto_Condensed -> ../../../../fonts/truetype/roboto/unhinted
    27034548      4 lrwxrwxrwx   1 root     root           63 Mar 22 00:34 /usr/share/webext/umatrix/css/fonts/fontawesome-webfont.ttf -> ../../../../fonts/truetype/font-awesome/fontawesome-webfont.ttf
    27034546      0 lrwxrwxrwx   1 root     root           27 Mar 22 00:34 /usr/share/webext/umatrix/assets/thirdparties/publicsuffix.org/list -> ../../../../../publicsuffix

For the following tests I used a temporary profile script:

   #!/bin/sh
   set -e
   dir="$(mktemp --tmpdir --directory firefox-esr-tmp-profile-XXXXXXXX)"
   cleanup () { rm --recursive --force "$dir"; }
   trap cleanup EXIT
   firefox-esr -no-remote -profile "$dir" "$@" || true

I noticed firefox-esr 68.6.0esr-1 still loads webext-* addons.

I noticed firefox 74.0-1 does not load any Debian addons at all.
Other Debian folks don't seem to have this issue, not sure why.

I noticed firefox-esr still has the problems with webext-umatrix.

Then I did the following workarounds:

$ sudo rm -f /usr/share/webext/umatrix/lib/codemirror ; sudo cp -a /usr/share/javascript/codemirror/ /usr/share/webext/umatrix/lib/codemirror
$ sudo rm -f /usr/share/webext/umatrix/lib/punycode.js ; sudo cp /usr/share/javascript/punycode/punycode.js /usr/share/webext/umatrix/lib/punycode.js
$ sudo rm -f /usr/share/webext/umatrix/lib/codemirror/codemirror.* ; sudo cp -a /usr/share/javascript/codemirror/lib/codemirror.* /usr/share/webext/umatrix/lib/codemirror/
$ sudo rm -f /usr/share/webext/umatrix/css/fonts/Roboto_Condensed ; sudo cp -a /usr/share/fonts/truetype/roboto/unhinted /usr/share/webext/umatrix/css/fonts/Roboto_Condensed
$ sudo rm -f /usr/share/webext/umatrix/css/fonts/fontawesome-webfont.ttf ; sudo cp -a /usr/share/fonts/truetype/font-awesome/fontawesome-webfont.ttf /usr/share/webext/umatrix/css/fonts/fontawesome-webfont.ttf
$ sudo rm -f /usr/share/webext/umatrix/assets/thirdparties/publicsuffix.org/list ; sudo cp -a /usr/share/publicsuffix /usr/share/webext/umatrix/assets/thirdparties/publicsuffix.org/list 
$ sudo rm -f /usr/share/webext/umatrix/assets/thirdparties/publicsuffix.org/list/effective_tld_names.dat ; sudo cp -a /usr/share/webext/umatrix/assets/thirdparties/publicsuffix.org/list/public_suffix_list.dat /usr/share/webext/umatrix/assets/thirdparties/publicsuffix.org/list/effective_tld_names.dat

The result was the following:

The My Rules page shows up sensibly.

I cannot load any sites, it just seems to spin around trying to load
and making no progress. If I have the network panel open in developer
tools it doesn't list any requests. When I disable the umatrix addon
then it immediately loads the site I was trying to load. It appears the
default rules have a block everything rule but even if I remove that
rule and reload the same thing happens. In my main profile I don't have
this issue for some reason.

The toolbar menu has some issues:

 * the size is wrong so the Revert all button is missing
 * I cannot select the global/domain scopes properly
 * the list of sites loaded by the page is not displayed, just the
   "all" line is present in the toolbar menu thing.
    * I observed this in my main profile since the temp profile didn't
      load any sites successfully.

-- 
bye,
pabs

https://wiki.debian.org/PaulWise
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part
URL: <http://alioth-lists.debian.net/pipermail/pkg-mozext-maintainers/attachments/20200322/3960b8f7/attachment-0002.sig>