[Pkg-openldap-devel] r1135 - in openldap/trunk/debian: . po

[Steve Langasek]

On Sun, May 25, 2008 at 08:06:16PM +0000, matthijs at alioth.debian.org wrote:

>  * Disabled the smbk5pwd again. It won't build, needs a build dependency on
>    OpenSSL.

> Modified: openldap/trunk/debian/rules
> ===================================================================
> --- openldap/trunk/debian/rules	2008-05-25 19:34:06 UTC (rev 1134)
> +++ openldap/trunk/debian/rules	2008-05-25 20:06:16 UTC (rev 1135)
> @@ -135,7 +135,6 @@
>  
>  	dh_installdirs -a
>  	cp -al $(installdir) $(tmpdir)
> -	sh debian/make_smbk5pwd
>  
>  	dh_install -a
>  	chmod 0755 $(CURDIR)/debian/slapd/usr/share/slapd/ldiftopasswd
> 
> 

Could we not clutter the source package with the unused make_smbk5pwd
script, then?  It's trivial to revive it from the VCS if it's needed later.

Also, this concerns me a bit:

> +#Package: slapd-smbk5pwd
> +#Section: net
> +#Priority: extra
> +#Architecture: any
> +#Depends: slapd (= ${binary:Version}), libkadm5srv8-heimdal (>= 1.0.1-5), libkrb5-22-heimdal (>= 1.0.1-5), libroken18-heimdal (>= 1.0.1-5), libasn1-8-heimdal (>= 1.0.1-5), libhx509-1-heimdal (>= 1.0.1-5), libhdb9-heimdal (>= 1.0.1-5)

Why are all of these dependencies hard-coded, instead of being picked up
automatically via dpkg-shlibdeps?  That's definitely a bug.

Cheers,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slangasek at ubuntu.com                                     vorlon at debian.org