[pkg-php-pear] Let's reconsider the way Symfony2 Components are packaged for Debian

[Daniel Beyer]

Hi David,

an other un-replied mail from the depth of this thread. If you feel my
reply leads to new matters that needs to be addressed, please open up a
new thread (as you did before) - Thanks, rest is found inline...

On Mon, 2014-09-08 at 10:04 -0400, David Prévot wrote:
> Hi,
> 
> Le 08/09/2014 02:35, Daniel Beyer a écrit :
> > On Sun, 2014-09-07 at 16:27 -0400, David Prévot wrote:
> >> Le 07/09/2014 15:28, Daniel Beyer a écrit :
> 
> >> - you may wish to regroup paragraphs about the same license.
> > 
> > Done, by respecting depths and wildcards. You can check that with:
> > # grep -E "^(License|Files):" debian/copyright
> 
> I actually meant “factorize”. E.g.:
>  (...)

Licensing should be clear now and has been discussed in an other thread:
http://lists.alioth.debian.org/pipermail/pkg-php-pear/2014-September/003520.html


> >>> - No tests are run, mainly due to two missing build-dependencies [1]. I
> >>> vote taking care about enabling tests during build after the package
> >>> made it into Debian.
> >>
> >> Please, just deactivate the tests you can’t run instead.
> > 
> > (...)

Test are now run (build + DEP-8). Further discussions in here:
http://lists.alioth.debian.org/pipermail/pkg-php-pear/2014-September/003527.html


> 
> > One more thing came up my mind while I grouped the licenses:
> > (...)

Licensing should be clear, see above.


> 
> FWIW, I reviewed Component/[B-I] yesterday, and hope to do more today
> (and if someone else intends to looks into Bridge or Bundle today,
> please, say so).
> 
> Some remarks (in no particular order) that crossed my mind while
> reviewing (some may be stupid: I haven’t yet rebuild or looked closely
> at the package, apologies if they are):
> - are you sure the “Test” (without final “s”) directories should be
>   stripped away?

Yes, I double checked and they only contain helper code related to tests
and are not needed during run time.


> - you may exclude (with -X) at dh_install time instead of deleting at
>   override_dh_auto_build time;

You already did that yourself - thanks a lot!
It inspired me to reduce complexity of d/rules even more - see commit
6faab753dc0dba49d3a110c275b949a2b5118b30 for details:
http://anonscm.debian.org/cgit/pkg-php/symfony.git/commit/?id=6faab753dc0dba49d3a110c275b949a2b5118b30


> - some README.md are useless and thus shouldn’t be shipped in the
>   package (e.g., src/Symfony/Component/PropertyAccess/README.md); maybe
>   the file size reflects its usefulness;

You're right. Since I did not want to blow up d/rules again, I simply
patched those out of upstreams code for now.


> - some package provides executables, maybe they should be moved in the
>   PATH if they are useful (with extra care to keep them working), or
>   not shipped at all if they aren’t (see Component/Intl/Resources/bin/);

I took a look at them and came to the result that they all are not
useful during runtime at all. Some of them even would not work due to
missing vendor/autoload.php normally created by composer. Since they are
not needed during build time, I patched them out of upstream's source,
too. 


> - if a binary package doesn’t provides it’s own changelog, maybe the
>   generic one could be used as a replacement;

Another task you already done - thanks!


> - I kinda liked the idea of a meta symfony package, what changed your
>   mind about it? (Thinking about doctrine and zendframework, I think it
>   will be nice to keep those (empty) packages once split too, but maybe
>   am I seeing it wrong);

I think php-symfony-framework-bundle does serve this purpose already.
But I'm open to re-add such a meta package again. But we maybe at least
do not depend on php-symfony-locale in it, since it is deprecated
starting with 2.3.
I'm not adding such a meta package back again for now, but if you still
think it should, fell free to open up a new thread.


> - you may wish to call mkdir with -p (in order to remove the earlier
>   mkdir, and thus save a few lines in d/rules that is already big: it
>   may make it more readable, or at least less frightening ;-).
> 

As mentioned above, I reduced complexity of d/rules and those directory
structures in d/build are gone now. I think it now is not too
frightening anymore. :-)


Greetings
Daniel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.alioth.debian.org/pipermail/pkg-php-pear/attachments/20140921/b2aa47e8/attachment-0001.sig>