[pkg-php-pear] RFS: php-nesbot-carbon

[David Prévot]

Hi Robin,

Le 13/04/2020 à 05:29, Robin Gustafsson a écrit :

> I've fixed your remarks and prepared a new version on Salsa [1].

>>   + please drop the version on pkg-php-tools, it’s already satisfied
>>     since before oldoldstable.
> 
> For my own future reference, is "drop the version [if] it's satisfied
> since before oldoldstable" a general rule?

Yes, even without any old: if it’s satisfied in the current stable, no
version should be needed.

Some more details: only one phpab template could be needed for the
testsuite with a common

	require_once 'Carbon/autoload.php';

You then “just” need to make sure src/ is in the path when you call the
testsuite during the build (less duplicated code, easier maintenance).

d/clean:
- a trailing backslash is needed to vendor/
- .phpunit.result.cache is missing

Better not push the debian tag before the package is actually uploaded
(it prevents one to make last minute changes, especially if the upload
fails for any packaging reason, or if the sponsor disagree with
uploading the package in its current state).

I don’t know why, but it seems I wasn’t affected test failure because of
"Expected: 'ar' Actual: 'ar_AE'" (looks applied upstream now anyway ;).

#!/usr/bin/php should probably be used instead of the env one for the
script.

I tried to use the script, but it seems it’s actually trying to install
itself (well, a “proper” carbon-cli dependency) via composer. If so, I
guess it’s at best useless as-is in Debian, sorry for advising adding it
without any idea what it was actually providing (I’ll blame the lack of
documentation…). If it’s providing something useful, it may be nice to
give a hint about it. If not, I’d suggest not shipping it (and possibly
dropping the php-cli dependency).

Regards

David

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-php-pear/attachments/20200414/b39ea60e/attachment.sig>