MoarVM 2015.05 needs mentor approval :-D

[Daniel Dehennin]

Paul Cochrane <paul at liekut.de> writes:

>> >   I had to revert a commit since it modify upstream source directly
>> 
>> That's the weird part: yesterday, I succesfully built moar with the 
>> modification done by Paul. This should have failed. I don't know what's wrong 
>> here.
>
> Yeah, sorry about that commit.  That was probably from when I was learning
> the ropes from a couple of months ago.
>
> Then again, if it's *not* some commit from a couple of months ago, have I
> done something that I shouldn't have?

AFAIK, any modification to upstream source must be made by patches in
debian/patches, otherwise building the source package will complain
about modification to upstream source:

    https://www.debian.org/doc/manuals/maint-guide/modify.en.html#fixupstream.

If we need to remove some non DFSG compliant files, we need to build a
new _dfsg.orig.tar.gz, that's the only case I know where a Debian
maintainer is permitted to modify upstream source directly.

>> > It build here in schroot using sbuild for Sid AMD64 and i386.
>
> I can confirm that it also builds for me on Jessie amd64.

Did it ask you to “commit” your changes (with dpkg-source --commit)?

I made a test commit and run debuild:

     dpkg-source -b pkg-moarvm
    dpkg-source: info: using source format `3.0 (quilt)'
    dpkg-source: info: building moarvm using existing ./moarvm_2015.05.orig.tar.gz
    dpkg-source: info: local changes detected, the modified files are:
      pkg-moarvm/Configure.pl
    dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/moarvm_2015.05-1.diff.TOfc97
    dpkg-source: info: you can integrate the local changes with dpkg-source --commit
    dpkg-buildpackage: error: dpkg-source -b pkg-moarvm gave error exit status 2
    debuild: fatal error at line 1376:
 
Regards.
-- 
Daniel Dehennin
Récupérer ma clef GPG: gpg --recv-keys 0xCC1E9E5B7A6FE2DF
Fingerprint: 3E69 014E 5C23 50E8 9ED6  2AAD CC1E 9E5B 7A6F E2DF
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 342 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-rakudo-devel/attachments/20150617/fb2aec80/attachment.sig>