[Pkg-roundcube-maintainers] Bug#1046449: roundcube: Fails to build source after successful build

[Lucas Nussbaum]

Source: roundcube
Version: 1.6.2+dfsg-1
Severity: minor
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
User: debian-qa at lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
> cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S
> ------------------------------------------------------------------------------------------------------------------------------
> 
> dpkg-buildpackage: info: source package roundcube
> dpkg-buildpackage: info: source version 1.6.2+dfsg-1
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by Guilhem Moulin <guilhem at debian.org>
>  dpkg-source --before-build .
>  debian/rules clean
> debian/rules:76: target 'skins/elastic/styles/styles.min.css.map' given more than once in the same rule
> debian/rules:76: target 'skins/elastic/styles/print.min.css.map' given more than once in the same rule
> debian/rules:76: target 'skins/elastic/styles/embed.min.css.map' given more than once in the same rule
> debian/rules:84: target 'program/js/publickey.min.js.gz' given more than once in the same rule
> debian/rules:84: target 'skins/elastic/styles/styles.min.css.gz' given more than once in the same rule
> debian/rules:84: target 'skins/elastic/styles/print.min.css.gz' given more than once in the same rule
> debian/rules:84: target 'skins/elastic/styles/embed.min.css.gz' given more than once in the same rule
> dh clean --with phpcomposer
>    dh_auto_clean
> 	make -j8 clean
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> rm -rf roundcubemail-git
> rm -rf roundcubemail-1.6-git*
> make[1]: Leaving directory '/<<PKGBUILDDIR>>'
>    debian/rules execute_after_dh_auto_clean
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> debian/rules:76: target 'skins/elastic/styles/styles.min.css.map' given more than once in the same rule
> debian/rules:76: target 'skins/elastic/styles/print.min.css.map' given more than once in the same rule
> debian/rules:76: target 'skins/elastic/styles/embed.min.css.map' given more than once in the same rule
> debian/rules:84: target 'program/js/publickey.min.js.gz' given more than once in the same rule
> debian/rules:84: target 'skins/elastic/styles/styles.min.css.gz' given more than once in the same rule
> debian/rules:84: target 'skins/elastic/styles/print.min.css.gz' given more than once in the same rule
> debian/rules:84: target 'skins/elastic/styles/embed.min.css.gz' given more than once in the same rule
> debconf-updatepo
> make[1]: Leaving directory '/<<PKGBUILDDIR>>'
>    dh_clean
>  dpkg-source -b .
> dpkg-source: warning: upstream signing key but no upstream tarball signature
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: building roundcube using existing ./roundcube_1.6.2+dfsg.orig-tinymce-langs.tar.xz
> dpkg-source: info: building roundcube using existing ./roundcube_1.6.2+dfsg.orig-tinymce.tar.xz
> dpkg-source: info: building roundcube using existing ./roundcube_1.6.2+dfsg.orig.tar.xz
> dpkg-source: info: using patch list from debian/patches/series
> dpkg-source: warning: newly created empty file 'temp/RCMTEMPattmnt64d73d7f469c5412614908' will not be represented in diff
> dpkg-source: warning: newly created empty file 'temp/RCMTEMPimgconvert64d73d7f469a2930266801' will not be represented in diff
> dpkg-source: info: local changes detected, the modified files are:
>  roundcube-1.6.2+dfsg/logs/errors.log
> dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/roundcube_1.6.2+dfsg-1.diff.1JxCfD
> dpkg-source: info: Hint: make sure the version in debian/changelog matches the unpacked source tree
> dpkg-source: info: you can integrate the local changes with dpkg-source --commit
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
> 
> E: Command 'cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/13/roundcube_1.6.2+dfsg-1_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.