[Pkg-samba-maint] samba 4.6.3 on mentors

[Jelmer Vernooij]

On Tue, May 02, 2017 at 05:09:47PM +0200, L.P.H. van Belle wrote:
> Hai, 
>  
> if anyone is interested, i have a new 4.6.3 build on mentors, any comments?  
>  
> https://mentors.debian.net/package/samba 

For the Samba package:

(Pedantic note: this is a non-developer *upload*, not a build. You're only
providing the source, the sponsor builds for one architecture and the buildds
build for the other architectures.)

This is not for Jessie (see my comments for the dependencies).

There is no need to refer to the full changelog, it is already shipped and installed in /usr/share/doc/samba/changelog.gz

Please mention the Debian bugs that were closed (https://bugs.debian.org/src:samba), with the "Closes: #" syntax, rather than cherry-picked upstream bugs.

Is there any reason you bumped the minimum version required for debhelper?
Please don't do this without a reason, it makes building the package on older
versions of Debian easier.

The changelog suggests that the version of libcmocka was "bumped", but AFAICT
there was no libcmocka dependency previously. Please document it as a new
dependency; Why is this dependency necessary?

Cheers,

Jelmer