[sane-devel] [sane-commit] [SCM] SANE backends - scanner drivers branch, master, updated. gitconversion-23-g3ba5515

[stef]

Le Sunday 10 May 2009 04:51:56 chris at cnpbagwell.com, vous avez écrit :
> The following commit has been merged in the master branch:
> commit 3ba551592c3ad71f82f6b0b2e19c248cc8fe40c1
> Author: chris at cnpbagwell.com <chris at cnpbagwell.com>
> Date:   Sat May 9 21:50:35 2009 -0500
>
>     Adding changelog for recent commit.
>
> diff --git a/ChangeLog b/ChangeLog
> index 0146403..e68983f 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,6 @@
> +2009-05-09 Chris Bagwell <cbagwell-guest at users.alioth.debian.org>
> +	* */*.c: standardize including local sane include files.
> +
>  2009-05-09  Nicolas Martin <nicols-guest at users.alioth.debian.org>
>  	* backend/pixma_mp150.c, doc/descriptions/pixma.desc:
>  	Fixed Pixma MP600 and MP600R for 2400 dpi scan, updated their
> descriptions.

	Hello,

	I have a couple of problems with commits regarding this entry.
	First I don't find */*.c a useful changelog entry. 
	Second, I really think that active maintainers should be asked on the sane-
devel list before changing the code they responsible for. Then go for the 
change if there is no answer in a decent amount of time.

	If it wasn't for this error:

Updating 4844785..3ba5515
error: Entry 'backend/genesys.c' not uptodate. Cannot merge.

	I wouldn't know about this change. I feel uncomfortable about a less trivial 
change that would sneak in a bug or regression without my knowledge.

	BTW is there any way to include the diffstat in commit messages ? I think 
this would make them more readable.

Regards,
	Stef