[sane-devel] [sane-commit] [SCM] SANE backends - scanner drivers branch, master, updated. gitconversion-23-g3ba5515

[Chris Bagwell]

On 05/11/2009 12:12 AM, stef wrote:
> Le Sunday 10 May 2009 04:51:56 chris at cnpbagwell.com, vous avez écrit :
>    
>> The following commit has been merged in the master branch:
>> commit 3ba551592c3ad71f82f6b0b2e19c248cc8fe40c1
>> Author: chris at cnpbagwell.com<chris at cnpbagwell.com>
>> Date:   Sat May 9 21:50:35 2009 -0500
>>
>>      Adding changelog for recent commit.
>>
>> diff --git a/ChangeLog b/ChangeLog
>> index 0146403..e68983f 100644
>> --- a/ChangeLog
>> +++ b/ChangeLog
>> @@ -1,3 +1,6 @@
>> +2009-05-09 Chris Bagwell<cbagwell-guest at users.alioth.debian.org>
>> +	* */*.c: standardize including local sane include files.
>> +
>>   2009-05-09  Nicolas Martin<nicols-guest at users.alioth.debian.org>
>>   	* backend/pixma_mp150.c, doc/descriptions/pixma.desc:
>>   	Fixed Pixma MP600 and MP600R for 2400 dpi scan, updated their
>> descriptions.
>>      
>
> 	Hello,
>
> 	I have a couple of problems with commits regarding this entry.
> 	First I don't find */*.c a useful changelog entry.
>    
Sorry, bit of laziness but hoped it read correctly in that every *.c 
file was touched in some way (at least by a sed script) and so this 
commit should be treated suspect as such.
> 	Second, I really think that active maintainers should be asked on the sane-
> devel list before changing the code they responsible for. Then go for the
> change if there is no answer in a decent amount of time.
>    
This is going to come up from time to time... There are housekeeping 
items I'd like to do such as these header bugfixes/cleanups (depending 
on file if its a bug), standardizing on stdint.h types when portability 
becomes an issue, etc.

I'd think this particular patch would bore people to death reading it 
but if authors prefer a heads up then not much issue from my side to 
publish diff to mailing list first.


> 	BTW is there any way to include the diffstat in commit messages ? I think
> this would make them more readable.
>    
I second that... I preferred the diffstat over actual diffs if thats 
possible.

Another would be to have the subject line contain diff summary instead 
of the current subject line its using.

Chris
> Regards,
> 	Stef
>
>
> --
> sane-devel mailing list: sane-devel at lists.alioth.debian.org
> http://lists.alioth.debian.org/mailman/listinfo/sane-devel
> Unsubscribe: Send mail with subject "unsubscribe your_password"
>               to sane-devel-request at lists.alioth.debian.org
>    

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/sane-devel/attachments/20090511/4991afb8/attachment.htm>