[PATCH 1/3] Drop superfluous global variable definitions
Ondřej Lysoněk
olysonek at redhat.com
Mon Feb 3 15:04:54 GMT 2020
The file minicom.c, by including the minicom.h header, already defines
the global variables 'dial_user' and 'dial_pass'. The object file
minicom.o is always linked to dial.o. Thus the definitions in dial.c
can be dropped.
This fixes linking with gcc 10 which uses -fno-common by default,
disallowing multiple global variable definitions.
---
src/dial.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/dial.c b/src/dial.c
index e6f9db1..5076b32 100644
--- a/src/dial.c
+++ b/src/dial.c
@@ -145,8 +145,6 @@ static int nrents = 1;
static int newtype;
/* Access to ".dialdir" denied? */
static int dendd = 0;
-char *dial_user;
-char *dial_pass;
/* Change the baud rate. Treat all characters in the given array as if
* they were key presses within the comm parameters dialog (C-A P) and
--
2.24.1
More information about the minicom-devel
mailing list